Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH-730 Validation for Applicable Types, & Notistack #261

Merged
merged 8 commits into from
Jan 17, 2024
Merged

CRDCDH-730 Validation for Applicable Types, & Notistack #261

merged 8 commits into from
Jan 17, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jan 11, 2024 •
edited
Loading

Overview

This PR disables validation types (metadata or files) for types that are not apart of the current data submission.

Change Details (Specifics)

  • Disable validation targets based on submission statuses
  • Marked GenericAlert as deprecated, it should not be used going forward for any new components or pages
  • Implemented Notistack as a replacement for GenericAlert, supports error, success, or default styles
  • Migrated a few utils to a separate utils file
  • Updated the CRDCDH-539 implementation to use a dynamic default selection (Metadata vs. Files) depending on what's currently uploaded

Related Ticket(s)

CRDCDH-730

@amattu2
CRDCDH-730 Disable disallowed validation targets
5b4c581 
Also migrates usage of GenericAlert to notistack for this comp.
@amattu2 amattu2 added this to the MVP-2.1.0 (M3) milestone Jan 11, 2024
@amattu2 amattu2 changed the title CRDCDH-730 Disable disallowed validation targets CRDCDH-730 Validation for Applicable Types, & Notistack Jan 11, 2024
@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Jan 12, 2024
@amattu2

This comment was marked as resolved.

Sign in to view
@amattu2 amattu2 marked this pull request as ready for review January 17, 2024 18:49
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Jan 17, 2024
Alejandro-Vega
Alejandro-Vega approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit 7b5c82e into mvp-2.1.0 Jan 17, 2024
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-730 branch January 17, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alejandro-Vega Alejandro-Vega Alejandro-Vega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0 (MVP2-M3)
Development

Successfully merging this pull request may close these issues.
2 participants
@amattu2 @Alejandro-Vega