Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH-603 Batch File List #256

Merged
merged 24 commits into from
Jan 12, 2024
Merged

CRDCDH-603 Batch File List #256

merged 24 commits into from
Jan 12, 2024

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented Jan 3, 2024 •
edited
Loading

Overview

This PR aims to make the file count clickable on the Batch table, which will bring up a dialog with a table with the file names and node types.

Change Details (Specifics)

  • Updated Batch table file count to be clickable
  • Added client-side pagination and sorting
  • Added FileListDialog with table containing fileName and nodeType from Batch files
  • Added border/borderRadius to GenericTable and adjusted loading content

Related Ticket(s)

CRDCDH-603

@Alejandro-Vega Alejandro-Vega added this to the MVP-2.1.0 (M3) milestone Jan 3, 2024
Base automatically changed from CRDCDH-660 to mvp-2.1.0 January 4, 2024 18:22
@Alejandro-Vega Alejandro-Vega added the 🚧 Do Not Merge This PR is not ready for merging label Jan 4, 2024
@Alejandro-Vega Alejandro-Vega marked this pull request as ready for review January 4, 2024 19:48
@Alejandro-Vega Alejandro-Vega removed the 🚧 Do Not Merge This PR is not ready for merging label Jan 11, 2024
amattu2
amattu2 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@amattu2 amattu2 merged commit 842267a into mvp-2.1.0 Jan 12, 2024
1 check passed
@amattu2 amattu2 deleted the CRDCDH-603 branch January 12, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amattu2 amattu2 amattu2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0 (MVP2-M3)
Development

Successfully merging this pull request may close these issues.
2 participants
@Alejandro-Vega @amattu2