Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-661 QC Results Filters #254

Merged
merged 17 commits into from
Jan 17, 2024
Merged

CRDCDH-661 QC Results Filters #254

merged 17 commits into from
Jan 17, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jan 3, 2024

Overview

This PR adds Data Submission Quality Control results filters to the QC Results tab

Change Details (Specifics)

  • Add 3 filters to the QC tab
  • Migrate the listBatches query schema to a set of fragments so the QC filters can reuse the same query

Related Ticket(s)

CRDCDH-661

@amattu2 amattu2 added this to the MVP-2.1.0 (M3) milestone Jan 3, 2024
@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Jan 12, 2024
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Jan 16, 2024
@amattu2 amattu2 marked this pull request as ready for review January 16, 2024 20:26
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be an issue when you set the rows per page to something smaller like 5, then you select a filter that doesn't have any results like Severity "Warning", then switch the filter back to "All". The table will show more than just 5 rows.

@amattu2
Copy link
Member Author

amattu2 commented Jan 17, 2024

@Alejandro-Vega There seems to be an issue when you set the rows per page to something smaller like 5, then you select a filter that doesn't have any results like Severity "Warning", then switch the filter back to "All". The table will show more than just 5 rows.

Since I was using handleFetchQCResults directly, any filter change didn't have the contextual information on the current rows per page; and using setPage with refresh caused the query to run twice (f0f0d49), so I modified the setPage implementation to also force-refetch data (d935ffa). I'm open to any suggestions for an improved approach.

Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit c752c6e into mvp-2.1.0 Jan 17, 2024
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-661 branch January 17, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants