Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-654 Export Submission on Release #250

Merged
merged 9 commits into from
Jan 18, 2024
Merged

CRDCDH-654 Export Submission on Release #250

merged 9 commits into from
Jan 18, 2024

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented Dec 27, 2023

Overview

This PR aims to export a submission when it is being released.

Change Details (Specifics)

  • Attempt to export submission when "Release" button is clicked. If it fails, then the submission is not released.
  • Migrate from GenericAlert to Notistack

NOTE: Branch is ahead of CRDCDH-730 and should be merged afterwards

Related Ticket(s)

CRDCDH-654

@Alejandro-Vega Alejandro-Vega added this to the MVP-2.1.0 (M3) milestone Dec 27, 2023
@Alejandro-Vega Alejandro-Vega changed the title CRDCDH-654 CRDCDH-654 Export Submission on Release Dec 27, 2023
@Alejandro-Vega Alejandro-Vega changed the base branch from mvp-2.1.0 to CRDCDH-730 January 17, 2024 15:49
@Alejandro-Vega Alejandro-Vega added the 🚧 Do Not Merge This PR is not ready for merging label Jan 17, 2024
@Alejandro-Vega Alejandro-Vega marked this pull request as ready for review January 17, 2024 16:16
Base automatically changed from CRDCDH-730 to mvp-2.1.0 January 17, 2024 19:50
@Alejandro-Vega Alejandro-Vega removed the 🚧 Do Not Merge This PR is not ready for merging label Jan 17, 2024
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend implementation works as expected. The BE seems to reject the export action unless the Data Curator is marked as the "Primary Contact" for that particular data submission. Based on the two tickets:

I believe any data curator should be able to export the data submission. We can merge this after confirming the correct implementation.

@amattu2 amattu2 merged commit 0b09571 into mvp-2.1.0 Jan 18, 2024
1 check passed
@amattu2 amattu2 deleted the CRDCDH-654 branch January 18, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants