Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-538 Data Submission Statistics #228

Merged
merged 15 commits into from
Dec 11, 2023
Merged

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Nov 27, 2023

Overview

This PR adds the Data Submission statistics area to the Data Submissions Overview Page. Per K.C. request, Figma design 1 was implemented, if we need to change the chart to a different style, a new user story will be created.

To test this PR, use the submissions:

Note: This is not a 1:1 implementation of the mockup. If this design does get approved, we will resolve any minor differences in UX QA.

Note: This PR introduces some 508 color contrast issues. These will be resolved when the other color scheme updates for CRDCDH-633 are provided.

Change Details (Specifics)

  • Upgraded minimum MUI-X Charts dependency to latest stable release
  • Modified the getSubmission query to also fetch submissionStats at the same time
  • Added Recharts for the primary donut chart
    • MUI-X does not appear to provide contextual info on which slice is currently hovered over, which prevents the ability to change the center label depending on what slice is active

Related Ticket(s)

https://tracker.nci.nih.gov/browse/CRDCDH-538

@amattu2 amattu2 added this to the MVP-2.1.0 (M3) milestone Nov 27, 2023
@amattu2 amattu2 changed the title CRDCDH-538 CRDCDH-538 Data Submission Statistics Nov 27, 2023
@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Nov 30, 2023
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Dec 11, 2023
@amattu2 amattu2 marked this pull request as ready for review December 11, 2023 19:16
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small optional changes requested. If will be fixed in future PR let me know.

package.json Outdated Show resolved Hide resolved
src/components/DataSubmissions/LegendItem.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, looks great!

@Alejandro-Vega Alejandro-Vega merged commit 1bb62a8 into mvp-2.1.0 Dec 11, 2023
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the amattu2/CRDCDH-538 branch December 11, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants