Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-621 Restore current URL on login #221

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Nov 21, 2023

Overview

This PR extends the existing "redirect after login" functionality to return back to the page the user pressed "Login" from; it effectively will only be useful for pages without authentication (e.g. Data Model Navigator).

Change Details (Specifics)

N/A

Related Ticket(s)

https://tracker.nci.nih.gov/browse/CRDCDH-621

@amattu2 amattu2 added this to the MVP-2.0.0 (M2) milestone Nov 21, 2023
Copy link
Contributor

@mtangmt mtangmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Working locally

Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit 67e8c11 into mvp-2 Nov 22, 2023
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the amattu2/CRDCDH-621 branch November 22, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants