CRDCDH-619 Switch from Session Storage to Cookies #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amattu2
added
📝 Change Requested
amattu2
removed
📝 Change Requested
mtangmt
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the missing sessionStorage data sync functionality that Bento apps have implemented. The mission functionality causes the Government Warning Banner to appear on every new tab you open, instead of just the first one opened.
Change Details (Specifics)
Related Ticket(s)
https://tracker.nci.nih.gov/browse/CRDCDH-619
https://tracker.nci.nih.gov/browse/CRDCDH-144