Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH-539 Initiate File Validations #217

Merged
merged 17 commits into from
Dec 11, 2023
Merged

CRDCDH-539 Initiate File Validations #217

merged 17 commits into from
Dec 11, 2023

Conversation

mtangmt
Copy link
Contributor

@mtangmt mtangmt commented Nov 20, 2023 •
edited by amattu2
Loading

Overview

This PR implements ticket 539, which is the file validation section inside of data submission dashboard.

Implementation details

  • This pr fixes styling for the radio buttons on non-chrome browsers, as I made a mistake in the styling
  • Adds the validation section inside of the data submission dashboard.

Related Tickets

CRDCDH-539
CRDCDH-540
CRDCDH-551

@mtangmt mtangmt added 🚧 Do Not Merge This PR is not ready for merging MVP-2.1.0 labels Nov 20, 2023
@mtangmt mtangmt added this to the MVP-2.1.0 (M3) milestone Nov 20, 2023
@mtangmt mtangmt marked this pull request as draft November 20, 2023 16:19
@amattu2 amattu2 changed the title Crdcdh 539 CRDCDH-539 Initiate File Validations Nov 28, 2023
@amattu2 amattu2 removed the MVP-2.1.0 label Nov 30, 2023
@amattu2 amattu2 marked this pull request as ready for review December 5, 2023 14:28
@amattu2
Copy link
Member

amattu2 commented Dec 5, 2023

The backend is not finished but it's implemented. Probably ready for review.

@amattu2 amattu2 added 🚧 Do Not Merge This PR is not ready for merging and removed 🚧 Do Not Merge This PR is not ready for merging labels Dec 5, 2023
@amattu2

This comment was marked as resolved.

Sign in to view
@amattu2 amattu2 self-assigned this Dec 8, 2023
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Dec 11, 2023
Alejandro-Vega
Alejandro-Vega approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit f444d74 into mvp-2.1.0 Dec 11, 2023
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-539 branch December 11, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alejandro-Vega Alejandro-Vega Alejandro-Vega approved these changes

Assignees

@amattu2 amattu2

Labels
None yet
Projects
None yet
Milestone
2.1.0 (MVP2-M3)
Development

Successfully merging this pull request may close these issues.
3 participants
@mtangmt @amattu2 @Alejandro-Vega