Skip to content

Commit

Permalink
Add release notes to manifest assets and update dataModelUtils tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Alejandro-Vega committed Jan 30, 2025
1 parent b1cdb46 commit d3c33c6
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/types/DataCommon.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ type ManifestAssets = {
* @example "README.md"
*/
"readme-file": string;
/**
* The file name of the Data Model release notes file.
*
* @example "release-notes.md"
*/
"release-notes": string;
/**
* The relative URL for the Model Navigator logo.
*
Expand Down
5 changes: 5 additions & 0 deletions src/utils/dataModelUtils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ describe("fetchManifest cases", () => {
"readme-file": "cds-model-readme.md",
"loading-file": "cds-loading.zip",
"current-version": "1.0",
"release-notes": "release-notes.md",
versions: [],
},
};
Expand All @@ -39,6 +40,7 @@ describe("fetchManifest cases", () => {
"readme-file": "cds-model-readme.md",
"loading-file": "cds-loading.zip",
"current-version": "1.0",
"release-notes": "release-notes.md",
versions: [],
},
};
Expand All @@ -60,6 +62,7 @@ describe("fetchManifest cases", () => {
"readme-file": "cds-model-readme.md",
"loading-file": "cds-loading.zip",
"current-version": "1.0",
"release-notes": "release-notes.md",
versions: [],
},
};
Expand Down Expand Up @@ -115,6 +118,7 @@ describe("buildAssetUrls cases", () => {
"model-files": ["model-file", "prop-file"],
"readme-file": "readme-file",
"loading-file": "loading-file-zip-name",
"release-notes": "release-notes.md",
} as ManifestAssets,
} as DataCommon;

Expand All @@ -128,6 +132,7 @@ describe("buildAssetUrls cases", () => {
readme: `${MODEL_FILE_REPO}prod/cache/test-name/1.0/readme-file`,
loading_file: `${MODEL_FILE_REPO}prod/cache/test-name/1.0/loading-file-zip-name`,
navigator_icon: expect.any(String),
changelog: `${MODEL_FILE_REPO}prod/cache/test-name/1.0/release-notes.md`,
});
});

Expand Down

0 comments on commit d3c33c6

Please sign in to comment.