Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for temp/download dir #31

Open
wants to merge 4 commits into
base: 1.2.0
Choose a base branch
from

Conversation

vshand11
Copy link
Collaborator

@vshand11 vshand11 commented Oct 9, 2024

Add s3 file existing and size

@vshand11 vshand11 changed the base branch from master to 1.2.0 October 9, 2024 15:00
@vshand11 vshand11 closed this Oct 9, 2024
@vshand11 vshand11 reopened this Oct 9, 2024
Copy link
Contributor

@n2iw n2iw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggestions:

  • Print/log an error message for each of the issues found during validation phase, currently only "Found total 1 file(s) are invalid!" is shown on console/log
  • The "succeeded" column for other files are empty, if they have been validated, then there should be a True for these files.

@vshand11
Copy link
Collaborator Author

vshand11 commented Oct 9, 2024

updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants