Split resolution metadata #112
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of data frame metadata using the
df.attrssemi-functionality in pandas is useful, but it has a bug/decision that produces an exception when doing dataframe concatenations because some of the metadata is kept as a list. This PR changes the table metadata format to split x/y/z into different fields, similar to how it's actually kept and transmitted. This is a mild breaking change for those who use thevoxel_resolutionfield right now (e.g. dash apps will need a one line fix in a few places), but I think it's useful to avoid a fairly cryptic error.