-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cable pop trendy blaze #435
base: CABLE-POP_TRENDY
Are you sure you want to change the base?
Conversation
Edits at 786b3b8 are science neutral. These remove many of the debugging write statements and reduced log files from ~190MB (for a 10 year, ACT9 case) to 27kB. |
edits to
Edits will follow the template set out for the other 1D variables. |
Edits up to 18695c9 are bitwise comparable in states and fluxes when compared to runs from the branch without any edits. New variables added are
Note that any downstream analyses that depend on NBP will need to be re-assess &/or adjusted to use NEP. |
Science changes to BLAZE internals are required in
We also need to check
|
71b773d contains changes in the science core of BLAZE and SIMFIRE. Interestingly applying these changes reduces the impact of simulated fire on the carbon stocks for the ACT9 test case. This comes from both from changes in BLAZE and the changes to SIMFIRE (mainly a resolution of inputs issue). There are remaining science questions to check with the development community. EDIT: looking at the code changes - this reversion back towards the no_fire case is expected. The science changes involved need to be partnered with changes inside POP (related to the evaluation of |
Also interesting to note that the run with the adjustments to simfire was A LOT faster (3.5 minutes vs 8.5 minutes) |
49a1dce hopefully includes all code changes to bring the science of BLAZE/SIMFIRE in the CABLE-POP_TRNDY branches to be in sync with the NESP2pt9/BLAZE_9184 branch. There are outstanding science questions that the community will need to resolve. There are also additional changes around the i/o code that need to be addressed so that the module can be run using a landmask/netCDF for all inputs rather than the binary inputs as currently. |
CABLE
Description
This dev branch includes revisions to facilitate the use of the fire model BLAZE (in conjunction with POP). This requires 3 tasks
NESP2pt9_BLAZE
andBLAZE_9184
branchesThis development work will be done based around the BIOS configuration/ACT9 test case and branches off the CABLE-POP_TRENDY branch. This configuration will use binary formats for many of the BIOS specific inputs as the work to convert these (gridinfo and meteorology read) remains to be completed.
You can link issues by using a supported keyword in the pull request's description or in a commit message:
Fixes #392
Relates/intersects with #232, #322, #391, #393
Type of change
Checklist
Please add a reviewer when ready for review.