Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py-icon4py] Fixing folder mapping for v0.0.10 #927

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

abishekg7
Copy link
Contributor

@abishekg7 abishekg7 commented Apr 1, 2024

Forgot to add this folder mapping for icon4py tag 0.0.10 when it was originally added. Only showed an error when we tried to build icon-dsl with this version of icon4py.

Copy link
Contributor

github-actions bot commented Apr 1, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-04-02 13:48 UTC

@abishekg7 abishekg7 marked this pull request as ready for review April 2, 2024 12:18
@abishekg7 abishekg7 requested a review from jonasjucker April 2, 2024 12:18
@jonasjucker
Copy link
Contributor

launch jenkins py-icon4py

Copy link
Contributor

@jonasjucker jonasjucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasjucker
Copy link
Contributor

I'll merge as soon as the test passes

@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec
🟢 system test
Test
🟢PyIcon4py-install_version_0_0_10
🟢PyIcon4py-install_version_0_0_3_1
🟢PyIcon4py-install_version_0_0_9

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec
🟢 system test
Test
🟢PyIcon4py-install_version_0_0_10
🟢PyIcon4py-install_version_0_0_3_1
🟢PyIcon4py-install_version_0_0_9

@jonasjucker jonasjucker merged commit da7a114 into main Apr 2, 2024
4 checks passed
@jonasjucker jonasjucker deleted the abishekg7_patch1 branch April 2, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants