Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev 0.22 #1011

Merged
merged 116 commits into from
Jan 28, 2025
Merged

Dev 0.22 #1011

merged 116 commits into from
Jan 28, 2025

Conversation

dominichofer
Copy link
Contributor

@dominichofer dominichofer commented Nov 5, 2024

Removes these packages:

  1. cosmo, because spack spec cosmo emites Error: Spack concretizer internal error. Please submit a bug report and include the command, environment if applicable and the following error message. cosmo is unsatisfiable
  2. fdb-fortran, because MeteoSwiss doesn't use it anymore.
  3. fdb, because the upstream package is sufficient.
  4. metkit, because the upstream package is sufficient.
  5. py-frozendict, , because the upstream package is sufficient.
  6. py-lark, because the upstream package is sufficient.
  7. xpmem, because the upstream package is sufficient.
  8. pytorch-fortran, because not needed anymore
  9. pytorch-fortran-proxy, because not needed anymore
  10. libtorch, because not needed anymore
  11. oasis, because not needed anymore
  12. int2lm because not needed anymore

Copy link
Contributor

github-actions bot commented Nov 5, 2024

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-01-28 16:03 UTC

* upgrade docs

* add yaml example

* update docs
@jonasjucker
Copy link
Contributor

launch jenkins

$ spack dev-build --until build <package> @<version>

This will build the package as is. The downside of this approach is that
you need to go through all phases of a package build.
Copy link
Contributor Author

@dominichofer dominichofer Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not true for icon. Icon sometimes skips stuff.

@jonasjucker
Copy link
Contributor

launch jenkins

stage('Create uenv') {
steps {
sh """
git clone -b fix/jenkins https://github.com/eth-cscs/uenv.git
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning: This is a branch!

@lxavier
Copy link
Contributor

lxavier commented Dec 20, 2024

FYI I manually tested this branch with v8 release candidate on Balfrin - ICON compiles but does not validate - this should be investigated before considering merging this branch

@huppd
Copy link
Contributor

huppd commented Dec 20, 2024

FYI I manually tested this branch with v8 release candidate on Balfrin - ICON compiles but does not validate - this should be investigated before considering merging this branch

Is this with new references? I think the optimization level has changed so, it might be just that.

@jonasjucker
Copy link
Contributor

FYI I manually tested this branch with v8 release candidate on Balfrin - ICON compiles but does not validate - this should be investigated before considering merging this branch

Is this with new references? I think the optimization level has changed so, it might be just that.

Indeed it was the different opt-level.

Using -O with 0.22 leads to

check.c2sm_clm_r13b03_seaice.run                  : OK (jobID:2025148)
check.mch_ch_lowres.run                           : OK (jobID:2025149)
check.mch_icon-ch1_small.run                      : OK (jobID:2025150)
check.mch_icon-ch2_small.run                      : OK (jobID:2025151)
check.mch_kenda-ch1_small.run                     : OK (jobID:2025152)
check.mch_opr_r04b07.run                          : OK (jobID:2025153)
check.mch_opr_r04b07_lhn_00.run                   : OK (jobID:2025154)
check.mch_opr_r04b07_lhn_12_emvorado.run          : OK (jobID:2025155)
check.mch_opr_r04b07_nest.run                     : OK (jobID:2025156)
check.mch_opr_r04b07_performance.run              : OK (jobID:2025157)
check.mch_opr_r04b07_sstice_inst.run              : OK (jobID:2025158)
check.mch_opr_r19b07_lpi.run                      : OK (jobID:2025159)
check.mch_opr_r19b07_turb.run                     : OK (jobID:2025160)
check.mch_pollen_test.run                         : OK (jobID:2025161)

Assuming compiler does still the right things with -O2 we can move on here

@huppd
Copy link
Contributor

huppd commented Jan 9, 2025

FYI I manually tested this branch with v8 release candidate on Balfrin - ICON compiles but does not validate - this should be investigated before considering merging this branch

Is this with new references? I think the optimization level has changed so, it might be just that.

Indeed it was the different opt-level.

Using -O with 0.22 leads to

check.c2sm_clm_r13b03_seaice.run                  : OK (jobID:2025148)
check.mch_ch_lowres.run                           : OK (jobID:2025149)
check.mch_icon-ch1_small.run                      : OK (jobID:2025150)
check.mch_icon-ch2_small.run                      : OK (jobID:2025151)
check.mch_kenda-ch1_small.run                     : OK (jobID:2025152)
check.mch_opr_r04b07.run                          : OK (jobID:2025153)
check.mch_opr_r04b07_lhn_00.run                   : OK (jobID:2025154)
check.mch_opr_r04b07_lhn_12_emvorado.run          : OK (jobID:2025155)
check.mch_opr_r04b07_nest.run                     : OK (jobID:2025156)
check.mch_opr_r04b07_performance.run              : OK (jobID:2025157)
check.mch_opr_r04b07_sstice_inst.run              : OK (jobID:2025158)
check.mch_opr_r19b07_lpi.run                      : OK (jobID:2025159)
check.mch_opr_r19b07_turb.run                     : OK (jobID:2025160)
check.mch_pollen_test.run                         : OK (jobID:2025161)

Assuming compiler does still the right things with -O2 we can move on here

Cool, thanks for testing :)

lxavier and others added 2 commits January 15, 2025 15:23
This is used with eccodes 2.36.4
This is required to test v8 env on balfrin
@lxavier
Copy link
Contributor

lxavier commented Jan 21, 2025

from MeteoSwiss side, we are now able to build icon using this branch on Balfrin with uenv mch/v8:rc4.

This is not a blocker to merge

@jonasjucker
Copy link
Contributor

launch jenkins

@jonasjucker
Copy link
Contributor

launch jenkins

@jonasjucker
Copy link
Contributor

all tests pass, except for the sql error in icon4py due to race condition.

Jenkinsfile Show resolved Hide resolved
@jonasjucker jonasjucker self-requested a review January 28, 2025 15:55
@jonasjucker jonasjucker merged commit 6ed9b0f into main Jan 28, 2025
2 checks passed
@jonasjucker jonasjucker deleted the dev_0.22 branch January 28, 2025 16:03
This was referenced Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants