Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Airspeed velocity performance regression CI #661

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
63b304e
Add initial ASV CI
iomaganaris Feb 7, 2025
6d8a6e8
Use benchmark.yml for asv for testing
iomaganaris Feb 7, 2025
4d4f124
Fixing $ in yml
iomaganaris Feb 7, 2025
ee35a83
Avoid using env variable in git commit for now
iomaganaris Feb 7, 2025
e437665
Place .asv-machine.json in right path
iomaganaris Feb 7, 2025
9f0d2c2
Remove unnecessary CI
iomaganaris Feb 7, 2025
7599cd8
Use /Users/ioannmag instead of ~
iomaganaris Feb 7, 2025
f34bb1a
Use https for results repo
iomaganaris Feb 7, 2025
e17e76a
Delete commit posting ci too
iomaganaris Feb 7, 2025
33edc22
Fix typo
iomaganaris Feb 7, 2025
71f9507
Set correct cli args for asv run
iomaganaris Feb 7, 2025
04eb10c
Trying to fix git issues
iomaganaris Feb 7, 2025
c8e9cc0
Clone repo
iomaganaris Feb 7, 2025
01b63c0
Clone again icon4py to fix issue with gitlabci not cloning again the …
iomaganaris Feb 7, 2025
33cd06f
Fix typo
iomaganaris Feb 7, 2025
1aee186
Use ssh url
iomaganaris Feb 7, 2025
61f5f7a
Try adding proxies for cloning git repo with ssh
iomaganaris Feb 7, 2025
2952290
Cp instead of cat
iomaganaris Feb 7, 2025
5e2634e
Create .ssh folder
iomaganaris Feb 8, 2025
885a56f
Install netcat in docker file as well
iomaganaris Feb 8, 2025
a9d0c7c
Trying to use github token for pushing gh-pages to repo
iomaganaris Feb 10, 2025
6fb96e9
Uninstall uv to avoid issues with asv
iomaganaris Feb 10, 2025
c714693
Add -y in pip uninstall
iomaganaris Feb 10, 2025
7833091
Trying to post comment with changes in performance and make CI fail i…
iomaganaris Feb 11, 2025
7736433
Fix used token
iomaganaris Feb 11, 2025
f64c793
Set PR ID properly
iomaganaris Feb 11, 2025
be90316
Compare latest commit with certain commit I have generated results fo…
iomaganaris Feb 11, 2025
e238b62
Remove export command
iomaganaris Feb 11, 2025
ea4e210
Just try to comment on the PR
iomaganaris Feb 11, 2025
8730061
Use right git commit ids for comparisson
iomaganaris Feb 11, 2025
337bd8d
Trying a bit different comment command
iomaganaris Feb 11, 2025
41d1f47
Trying a different way to write a comment
iomaganaris Feb 11, 2025
52a4cd0
Trying to fix comment style
iomaganaris Feb 12, 2025
2240115
Trying with split in asv compare and -x for debug
iomaganaris Feb 12, 2025
786fbac
Trying to format properly the comment
iomaganaris Feb 12, 2025
c59038b
Fix typo
iomaganaris Feb 12, 2025
c5f7fc8
Trying different way to format the comment
iomaganaris Feb 12, 2025
4862025
Try formatting with "
iomaganaris Feb 12, 2025
9450648
Remove typo
iomaganaris Feb 12, 2025
8083f97
Trying json format fix and make factor in comparison lower
iomaganaris Feb 12, 2025
ce73ffa
Fix comment without jq
iomaganaris Feb 12, 2025
e4555cc
Rename COMMIT variable name and improve a bit printing on the CI logs
iomaganaris Feb 12, 2025
72d25a5
Also show only changed results
iomaganaris Feb 12, 2025
24c7ae4
Added comments with TODOs and trying to fix PR comment style with cus…
iomaganaris Feb 12, 2025
f50fa80
Fix commit and CI log output
iomaganaris Feb 12, 2025
6886646
Fix grep command
iomaganaris Feb 12, 2025
b064392
Trying to fix ci log
iomaganaris Feb 12, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 0 additions & 38 deletions .github/workflows/deploy-docs.yml

This file was deleted.

36 changes: 0 additions & 36 deletions .github/workflows/icon4py-qa.yml

This file was deleted.

36 changes: 0 additions & 36 deletions .github/workflows/mandatory_and_optional_test_reminder.yml

This file was deleted.

203 changes: 203 additions & 0 deletions asv.conf.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,203 @@
{
// The version of the config file format. Do not change, unless
// you know what you are doing.
"version": 1,

// The name of the project being benchmarked
"project": "icon4py",

// The project's homepage
"project_url": "https://github.com/C2SM/icon4py",

// The URL or local path of the source code repository for the
// project being benchmarked
"repo": ".",

// The Python project's subdirectory in your repo. If missing or
// the empty string, the project is assumed to be located at the root
// of the repository.
// "repo_subdir": "",

// Customizable commands for building the project.
// See asv.conf.json documentation.
// To build the package using pyproject.toml (PEP518), uncomment the following lines
"build_command": ["uv pip install ."
// "python3.11 -c \"import os; print(os.environ.get('GT4PY_BACKEND'))\"",
// "python3.11 {conf_dir}/asv_util/run_tests.py"
],
// To build the package using setuptools and a setup.py file, uncomment the following lines
// "build_command": [
// "python setup.py build",
// "python -mpip wheel -w {build_cache_dir} {build_dir}"
// ],

// Customizable commands for installing and uninstalling the project.
// See asv.conf.json documentation.
"install_command": [
// "uv pip install .",
// "python3.11 -c \"import os; print(os.environ.get('GT4PY_BACKEND'))\"",
// "pytest model/atmosphere/dycore/tests --benchmark-json {build_dir}/benchmark_{commit}_{GT4PY_BACKEND}_{ICON4PY_GRID}.json --benchmark-only --memray --backend {GT4PY_BACKEND} --grid {ICON4PY_GRID} -k TestFusedSolveNonhydroStencil39To40 --benchmark-min-rounds=1"
"python {conf_dir}/asv_util/run_tests.py"
],
// "uninstall_command": ["return-code=any python -mpip uninstall -y {project}"],

// List of branches to benchmark. If not provided, defaults to "main"
// (for git) or "default" (for mercurial).
"branches": ["asv_test"], // for git
// "branches": ["default"], // for mercurial

// The DVCS being used. If not set, it will be automatically
// determined from "repo" by looking at the protocol in the URL
// (if remote), or by looking for special directories, such as
// ".git" (if local).
"dvcs": "git",

// The tool to use to create environments. May be "conda",
// "virtualenv", "mamba" (above 3.8)
// or other value depending on the plugins in use.
// If missing or the empty string, the tool will be automatically
// determined by looking for tools on the PATH environment
// variable.
"environment_type": "virtualenv",

// timeout in seconds for installing any dependencies in environment
// defaults to 10 min
"install_timeout": 2400,

// the base URL to show a commit for the project.
// "show_commit_url": "http://github.com/owner/project/commit/",

// The Pythons you'd like to test against. If not provided, defaults
// to the current version of Python used to run `asv`.
// "pythons": ["3.8", "3.12"],

// The list of conda channel names to be searched for benchmark
// dependency packages in the specified order
// "conda_channels": ["conda-forge", "defaults"],

// A conda environment file that is used for environment creation.
// "conda_environment_file": "environment.yml",

// The matrix of dependencies to test. Each key of the "req"
// requirements dictionary is the name of a package (in PyPI) and
// the values are version numbers. An empty list or empty string
// indicates to just test against the default (latest)
// version. null indicates that the package is to not be
// installed. If the package to be tested is only available from
// PyPi, and the 'environment_type' is conda, then you can preface
// the package name by 'pip+', and the package will be installed
// via pip (with all the conda available packages installed first,
// followed by the pip installed packages).
//
// The ``@env`` and ``@env_nobuild`` keys contain the matrix of
// environment variables to pass to build and benchmark commands.
// An environment will be created for every combination of the
// cartesian product of the "@env" variables in this matrix.
// Variables in "@env_nobuild" will be passed to every environment
// during the benchmark phase, but will not trigger creation of
// new environments. A value of ``null`` means that the variable
// will not be set for the current combination.
//
"matrix": {
"req": {
"uv": [],
"pytest": [],
"pytest-benchmark": [],
"git+https://github.com/iomaganaris/pytest-memray.git@pytest_json": [],
"nvidia-cuda-runtime-cu12==12.6.77": [],
"cupy-cuda12x": [],
},
"env": {"GT4PY_BACKEND": ["gtfn_cpu", "gtfn_gpu"], "ICON4PY_GRID": ["icon_grid", "icon_grid_global"], "MEMRAY": ["ON", null]},
// "env_nobuild": {"ENV_VAR_2": ["val3", null]},
},


// Combinations of libraries/python versions can be excluded/included
// from the set to test. Each entry is a dictionary containing additional
// key-value pairs to include/exclude.
//
// An exclude entry excludes entries where all values match. The
// values are regexps that should match the whole string.
//
// An include entry adds an environment. Only the packages listed
// are installed. The 'python' key is required. The exclude rules
// do not apply to includes.
//
// In addition to package names, the following keys are available:
//
// - python
// Python version, as in the *pythons* variable above.
// - environment_type
// Environment type, as above.
// - sys_platform
// Platform, as in sys.platform. Possible values for the common
// cases: 'linux2', 'win32', 'cygwin', 'darwin'.
// - req
// Required packages
// - env
// Environment variables
// - env_nobuild
// Non-build environment variables
//
"exclude": [
// {"python": "3.2", "sys_platform": "win32"}, // skip py3.2 on windows
// {"environment_type": "conda", "req": {"six": null}}, // don't run without six on conda
// {"env": {"ENV_VAR_1": "val2"}}, // skip val2 for ENV_VAR_1
{"env": {"GT4PY_BACKEND": "gtfn_gpu", "MEMRAY": "ON"}},
],
//
// "include": [
// // additional env for python3.12
// {"python": "3.12", "req": {"numpy": "1.26"}, "env_nobuild": {"FOO": "123"}},
// // additional env if run on windows+conda
// {"platform": "win32", "environment_type": "conda", "python": "3.12", "req": {"libpython": ""}},
// ],

// The directory (relative to the current directory) that benchmarks are
// stored in. If not provided, defaults to "benchmarks"
// "benchmark_dir": "benchmarks",

// The directory (relative to the current directory) to cache the Python
// environments in. If not provided, defaults to "env"
"env_dir": ".asv/env",

// The directory (relative to the current directory) that raw benchmark
// results are stored in. If not provided, defaults to "results".
"results_dir": ".asv/results",

// The directory (relative to the current directory) that the html tree
// should be written to. If not provided, defaults to "html".
"html_dir": ".asv/html",

// The number of characters to retain in the commit hashes.
// "hash_length": 8,

// `asv` will cache results of the recent builds in each
// environment, making them faster to install next time. This is
// the number of builds to keep, per environment.
// "build_cache_size": 2,

// The commits after which the regression search in `asv publish`
// should start looking for regressions. Dictionary whose keys are
// regexps matching to benchmark names, and values corresponding to
// the commit (exclusive) after which to start looking for
// regressions. The default is to start from the first commit
// with results. If the commit is `null`, regression detection is
// skipped for the matching benchmark.
//
// "regressions_first_commits": {
// "some_benchmark": "352cdf", // Consider regressions only after this commit
// "another_benchmark": null, // Skip regression detection altogether
// },

// The thresholds for relative change in results, after which `asv
// publish` starts reporting regressions. Dictionary of the same
// form as in ``regressions_first_commits``, with values
// indicating the thresholds. If multiple entries match, the
// maximum is taken. If no entry matches, the default is 5%.
//
// "regressions_thresholds": {
// "some_benchmark": 0.01, // Threshold of 1%
// "another_benchmark": 0.5, // Threshold of 50%
// },
}
11 changes: 11 additions & 0 deletions asv_util/asv-machine.santis.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"gh200": {
"arch": "aarch64",
"cpu": "GH200 (72 cores)",
"machine": "gh200",
"num_cpu": "288",
"os": "Linux 5.14.21",
"ram": "854 GB"
},
"version": 1
}
31 changes: 31 additions & 0 deletions asv_util/run_tests.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import pytest
import os

GT4PY_BACKEND = os.environ.get("GT4PY_BACKEND", None)
if GT4PY_BACKEND is None:
print("Error: GT4PY_BACKEND environment variable is not set.")
exit(1)
ICON4PY_GRID = os.environ.get("ICON4PY_GRID", None)
if ICON4PY_GRID is None:
print("Error: ICON4PY_GRID environment variable is not set.")
exit(1)
BENCHMARK_DIR = os.environ.get("ASV_BUILD_DIR", None)
if BENCHMARK_DIR is None:
print("Error: ASV_BUILD_DIR environment variable is not set.")
exit(1)
COMMIT_HASH = os.environ.get("ASV_COMMIT", None)
if COMMIT_HASH is None:
print("Error: COMMIT_HASH environment variable is not set.")
exit(1)
MEMRAY = os.environ.get("MEMRAY", None)
BENCHMARK_RUNTIME_FILENAME = "benchmark_runtime_{}_{}_{}.json".format(COMMIT_HASH, GT4PY_BACKEND, ICON4PY_GRID)
BENCHMARK_MEMRAY_FILENAME = "benchmark_memray_{}_{}_{}.json".format(COMMIT_HASH, GT4PY_BACKEND, ICON4PY_GRID)

benchmark_runtime_file_path = os.path.join(BENCHMARK_DIR, BENCHMARK_RUNTIME_FILENAME) if BENCHMARK_DIR else BENCHMARK_RUNTIME_FILENAME
benchmark_memray_file_path = os.path.join(BENCHMARK_DIR, BENCHMARK_MEMRAY_FILENAME) if BENCHMARK_DIR else BENCHMARK_MEMRAY_FILENAME

if os.environ.get("MEMRAY", None) is None:
pytest.main([os.path.join(os.path.dirname(__file__), "../model/atmosphere/dycore/tests"), "--benchmark-json", benchmark_runtime_file_path, "--benchmark-only", "--backend", GT4PY_BACKEND, "--grid", ICON4PY_GRID, "-k", "test_fused_velocity_advection_stencil_15_to_18", "--benchmark-min-rounds=1"])
else:
pytest.main([os.path.join(os.path.dirname(__file__), "../model/atmosphere/dycore/tests"), "--benchmark-json", benchmark_memray_file_path, "--benchmark-only", "--backend", GT4PY_BACKEND, "--grid", ICON4PY_GRID, "-k", "test_fused_velocity_advection_stencil_15_to_18", "--benchmark-min-rounds=1", "--memray"])

20 changes: 20 additions & 0 deletions benchmarks/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Write the benchmarking functions here.
# See "Writing benchmarks" in the asv docs for more information.

import benchmarks.setup_tests as setup_tests

class BenchmarkMetaclass(type):
def __dir__(cls):
return list(setup_tests.BENCHMARKS.keys())
def __getattr__(cls, name):
if not name.startswith(setup_tests.PREFIX):
raise AttributeError
setattr(cls, name, setup_tests.BENCHMARKS[name])
return getattr(cls, name)

class Benchmarks(metaclass=BenchmarkMetaclass):
def __getattr__(self, name):
if not name.startswith(setup_tests.PREFIX):
raise AttributeError
setattr(type(self), name, setup_tests.BENCHMARKS[name])
return getattr(self, name)
Loading