Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move scidoc to docstrings of individual stencils #651

Closed
wants to merge 2 commits into from

Conversation

halungge
Copy link
Contributor

@halungge halungge commented Jan 29, 2025

Move the #scidoc strings from SolveNonHydro and VelocityAdvection to the doc string of the individual stencil field operators.

  • Adapted some of the outputs and input namings where they changed from the stencil call to the stencil implementation
  • Split some of the #scidocs were they collected previousely fused stencils that most likely will not longer be used.

Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@halungge halungge changed the title moving scidoc to stencils, version 1 move scidoc to docstrings of individual stencils Jan 30, 2025
@halungge halungge requested a review from jcanton January 30, 2025 08:47
@halungge
Copy link
Contributor Author

cscs-ci run default

@halungge halungge closed this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant