Update to GT4Py:main #596
Open
Update to GT4Py:main #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cscs-ci run default |
|
cscs-ci run default |
|
cscs-ci run default |
halungge
reviewed
Dec 10, 2024
| @@ -445,8 +446,8 @@ def _get_offset_providers(self, grid: icon_grid.IconGrid) -> dict[str, gtx.Field | |||
| horizontal_offsets = { | |||
| k: v | |||
| for k, v in grid.offset_providers.items() | |||
| if isinstance(v, gtx.NeighborTableOffsetProvider) | |||
| and v.origin_axis.kind == gtx.DimensionKind.HORIZONTAL | |||
| if isinstance(v, gtx.Connectivity) | |||
There was a problem hiding this comment.
We should be able to remove this workaround with PR 1746...
|
cscs-ci run default |
|
cscs-ci run dace |
edopao
reviewed
Dec 20, 2024
pyproject.toml
Outdated
| @@ -109,8 +109,7 @@ explicit = true | |||
|
|
|||
| [tool.uv.sources] | |||
| # ghex = { git = "https://github.com/ghex-org/GHEX.git", branch = "master"} | |||
| # TODO(egparedes): use GT4Py tagged release until #596 & gt4py#1738 are merged | |||
| gt4py = { git = "https://github.com/GridTools/gt4py", tag = "icon4py_20241113" } | |||
| gt4py = { git = "https://github.com/GridTools/gt4py.git", branch = "main" } | |||
There was a problem hiding this comment.
I took the freedom to update this PR and merge the latest icon4py main, in order to include the uv development environment.
While merging, I reverted a change from @havogt, that used a custom gt4py branch. If needed, you can re-apply it by changing this line:
Suggested change
| gt4py = { git = "https://github.com/GridTools/gt4py.git", branch = "main" } | |
| gt4py = { git = "https://github.com/havogt/gt4py.git", branch = "increase_inlining_loop" } |
|
cscs-ci run default |
|
cscs-ci run default |
|
cscs-ci run default |
|
cscs-ci run default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by
GridTools/gt4py#1738,GridTools/gt4py#1648, GridTools/gt4py#1764TODO: add a better PR title before merging, the current title is to connect it with the cycle task.