Pin Python version to be consistent with aiida-icon #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoscinski
force-pushed
the
pin-python312
branch
from
3e60e5b to
d320402
Compare
agoscinski
commented
Oct 17, 2024
| @@ -43,10 +43,10 @@ jobs: | |||
| timeout-minutes: 15 | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - name: Set up Python ${{ matrix.python-version }} | |||
There was a problem hiding this comment.
These were wrong because for docs and formatting we anyway want to use a fixed version
To be consistent with aiida-icon.
To be consistent with aiida-icon.
agoscinski
force-pushed
the
pin-python312
branch
from
d320402 to
133679e
Compare
agoscinski
commented
Oct 17, 2024
| inputs: Optional[list[ConfigCycleTaskInput | str]] = Field(default_factory=list) | ||
| outputs: Optional[list[ConfigCycleTaskOutput | str]] = Field(default_factory=list) | ||
| depends: Optional[list[ConfigCycleTaskDepend | str]] = Field(default_factory=list) | ||
| inputs: list[ConfigCycleTaskInput | str] | None = Field(default_factory=list) |
There was a problem hiding this comment.
changes needed because formatter complained
agoscinski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.