Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep alive #432

Merged
merged 7 commits into from
Mar 11, 2024
Merged

Keep alive #432

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6a0457a
Allow users to handle invalid nodes coming from a search against the API
InnocentBug Feb 27, 2024
e7bfa35
fix issues and shorten test
InnocentBug Feb 27, 2024
ef52db0
first steps
InnocentBug Feb 27, 2024
0102829
trying somehting
InnocentBug Feb 27, 2024
ea8c833
add exception raising for uninitialized API usage
InnocentBug Feb 28, 2024
7aa8b30
add more documentation for user
InnocentBug Feb 28, 2024
1b89619
Merge branch 'develop' into keep-alive
InnocentBug Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/api/test_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,12 @@ def test_api_search_node_type(cript_api: cript.API) -> None:
materials_paginator.auto_load_nodes = True
except StopIteration:
break
# We don't need to search for a million pages here.
if materials_paginator._number_fetched_pages > 6:
break

# Assure that we paginated more then one page
assert materials_paginator.page_number == 6
assert materials_paginator._number_fetched_pages > 0
assert len(materials_list) > 5
first_page_first_result = materials_list[0].name
# just checking that the word has a few characters in it
Expand Down
Loading