load_nodes_from_json works with both str and dict args
#398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes the function a more versatile and makes user scripts easier to write since they don't have to change formats. The code written for it is pretty clean and nice to work with I think.
|
Merging to
|
|
need to update code example with doctest after this PR is in #371 |
InnocentBug
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
load_nodes_from_jsonworks with both str and dict argsthis makes the function a more versatile and makes user scripts easier to write since they don't have to change formats.
The code written for it is pretty clean and nice to work with I think.
Changes
load_nodes_from_jsonaccepts with JSON str or dict argumentsload_nodes_from_jsonusing a JSON dict argumentKnown Issues
Notes
Checklist
CONTRIBUTORS.md) in the pull request source branch.