-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B2ShapeCast #21
base: master
Are you sure you want to change the base?
B2ShapeCast #21
Conversation
Perform a linear shape cast of shape B moving and shape A fixed. Determines the hit point, normal, and translation fraction.
Could you please add a few test cases? Ideally the same than upstream |
I will look into adding tests. This was a rather recent addition so I have not checked how to use it. But right now on go 1.13.7 all the tests fail because of Printf formatting. Maybe I should fix the formatting for existing tests first? |
Hey @Alexander-r I went ahead and proposed a PR fixing the issue you put forward on go 1.13. Thanks for doing so! |
I merged #24 into master. Tests should be good on go 1.13 now if you rebase. |
Would something like that be enough for a test? My C++ version for comparing the output: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Perform a linear shape cast of shape B moving and shape A fixed.
Determines the hit point, normal, and translation fraction.
Ported from upstream.