Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/148 add linters and prettier to project #156

Merged
merged 25 commits into from
Oct 5, 2024
Merged

Feature/148 add linters and prettier to project #156

merged 25 commits into from
Oct 5, 2024

Conversation

KC900201
Copy link
Contributor

@KC900201 KC900201 commented Oct 5, 2024

Issue Banner Image

Describe the bug

  • A few source codes in the repo have linting errors.

To Reproduce

  • Steps to reproduce the behavior:
    • Navigate to the mentioned source codes for example:
    • hero-action.ts
    • BaseLayout.astro

Expected behaviour

  • Linting errors should be prevented by prefixing the coding before performing git commit to prevent errors.
  • Solution: some errors that may caused by Typescript compilation. We can perform type-guarding to predefine the variables

Solution

  • Implement linter and code styling checker in project with Prettier + Eslint
  • Implement @ts-nocheck on google-tag scripting (temporary solution)

Reference

Screenshots

  • BaseLayout.astro

image

  • hero-action.ts
    image

image

KC900201 and others added 25 commits September 16, 2024 10:40
@KC900201 @Buzzpy
Feature/139 update read me sections (Buzzpy#143)
bc05692 
* Created issue templates

* Update add-a-new-term.md

* Update add-a-new-term.md

* Update add-a-new-term.md

* Update add-a-new-term.md

* Update bug_report.md

* Update add-a-new-term.md

* Update bug_report.md

* Update README.md

* Update add-a-new-term.md

* Update add-a-new-term.md

* Update add-a-new-term.md

* Update README.md

Included Tech Stack, installation and Deployment sections

---------

Co-authored-by: Chenuli Jayasinghe <[email protected]>
@Akshay-Vs
chore: add commit lint configuration
0252243
@Akshay-Vs
chore: add Husky and configure Git hooks
fdcc535
@Akshay-Vs
ci: add GitHub Actions workflow for building and testing Astro app
3f3e9db
@Buzzpy
Merge pull request Buzzpy#146 from Akshay-Vs/master
f89ad7d 
chore: add Husky, configure pre-commit and commit-msg hooks, and set up Commitlint
@KC900201
fix: Correct the spelling error for CI term
6708a5e
@KC900201
feature: add new term - CI/CD
083cdc9
@KC900201
Merge branch 'develop' into feature/151_add_new_term_cicd
3537ae0
@TahaHameed23
add:monorepo term & renamed Svelt to Svelte.json
24b1877
@TahaHameed23
add:monorepo term & renamed Svelt to Svelte.json
57e1db1
@TahaHameed23
Merge branch 'develop' into new-term
62b15a5
@Buzzpy
Merge pull request Buzzpy#153 from KC900201/feature/151_add_new_term_…
700a2ae 
…cicd

Feature/151 add new term cicd
@Buzzpy
Merge pull request Buzzpy#154 from TahaHameed23/new-term
8e4775d 
Added a new term:  "Monorepo" + fixed a filename typo for Svelte.json
@KC900201
fix: include conditional checking for undefined variables
2fd7316
@KC900201
feature: setting up prettier and eslint configuration for project
f0b8e24
@KC900201
feature: fix linting on files
6850c88
@KC900201
feature: fix linting on files
714a45f
@KC900201
feature: fix linting on files
6529882
@KC900201
feature: update comments and default settings for vscode
9774376
@KC900201
fix: remove md and mdx files from prettier command
0214001
@KC900201
fix: rewrite single quote to double quote
2306f11
@KC900201
fix: remove singleQuote option
872ec13
@KC900201
feature: update configuration for prettier setup
40dcb66
@KC900201
feature: update configuration for prettier setup on astro files
63f8fbd
@KC900201
fix: (WIP) implement ts-nocheck for google-tag scripting
b8057a4
@KC900201 KC900201 mentioned this pull request Oct 5, 2024
Closed
@Buzzpy Buzzpy merged commit 6345b4e into Buzzpy:master Oct 5, 2024
2 checks passed
@KC900201 KC900201 deleted the feature/148_add_linters_and_prettier_to_project branch October 6, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Buzzpy Buzzpy Buzzpy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KC900201 @Buzzpy @Akshay-Vs @TahaHameed23