Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the callback from the handler when the activity is destroyed #361

Open
wants to merge 3 commits into
base: bug-fixes
Choose a base branch
from
Open

Removes the callback from the handler when the activity is destroyed #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f379a07
Removes the callback from the handler when the activity is destroyed
saketkumar Jan 2, 2017
4470b12
Reformated the code
saketkumar Jan 19, 2017
a8dfcb4
Merge branch 'bug-fixes' into leak
saketkumar95 Jan 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 30 additions & 19 deletions source-code/app/src/main/java/org/buildmlearn/toolkit/activity/HomeActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
package org.buildmlearn.toolkit.activity;

import android.app.Fragment;
import android.app.FragmentManager;
import android.app.FragmentTransaction;
import android.content.Intent;
import android.content.SharedPreferences;
import android.graphics.drawable.ColorDrawable;
import android.os.Build;
import android.os.Bundle;
import android.os.Handler;
import android.preference.PreferenceManager;
import android.support.design.widget.NavigationView;

import android.support.design.widget.NavigationView
import android.app.FragmentManager;
import android.support.v4.content.ContextCompat;
import android.support.v4.view.GravityCompat;
import android.os.Handler;
import android.support.v4.widget.DrawerLayout;
import android.support.v7.app.AppCompatActivity;
import android.support.v7.widget.Toolbar;
Expand All @@ -30,6 +30,8 @@
import org.buildmlearn.toolkit.fragment.SettingsFragment;
import org.buildmlearn.toolkit.utilities.SmoothNavigationToggle;

;

/**
* @brief Home screen of the application containg all the menus and settings.
*/
Expand All @@ -40,12 +42,13 @@ public class HomeActivity extends AppCompatActivity
private final String FRAGMENT_TAG_HOME = "Home";
private final String FRAGMENT_TAG_PROJECT = "Project";
private final String FRAGMENT_TAG_APK = "Apk";
NavigationView navigationView;
private boolean backPressedOnce = false;

private Runnable runnable;
private Handler handler = new Handler();
private long timer = 2000;
private SmoothNavigationToggle smoothNavigationToggle;

private NavigationView navigationView;

/**
* {@inheritDoc}
*/
Expand All @@ -72,7 +75,7 @@ protected void onCreate(Bundle savedInstanceState) {

DrawerLayout drawer = (DrawerLayout) findViewById(R.id.drawer_layout);
smoothNavigationToggle = new SmoothNavigationToggle(
this, drawer, toolbar, R.string.navigation_drawer_open, R.string.navigation_drawer_close){
this, drawer, toolbar, R.string.navigation_drawer_open, R.string.navigation_drawer_close) {
@Override
public void onDrawerOpened(View drawerView) {
super.onDrawerOpened(drawerView);
Expand Down Expand Up @@ -130,7 +133,7 @@ public void run() {
@Override
public void run() {
fragmentManager.beginTransaction().setTransition(FragmentTransaction.TRANSIT_FRAGMENT_FADE)
.replace(R.id.container, new LoadProjectFragment(),FRAGMENT_TAG_PROJECT).commit();
.replace(R.id.container, new LoadProjectFragment(), FRAGMENT_TAG_PROJECT).commit();
if (getSupportActionBar() != null) {
getSupportActionBar().setTitle(R.string.menu_load_project);
}
Expand All @@ -143,7 +146,7 @@ public void run() {
@Override
public void run() {
fragmentManager.beginTransaction().setTransition(FragmentTransaction.TRANSIT_FRAGMENT_FADE)
.replace(R.id.container, new LoadApkFragment(),FRAGMENT_TAG_APK).commit();
.replace(R.id.container, new LoadApkFragment(), FRAGMENT_TAG_APK).commit();
if (getSupportActionBar() != null) {
getSupportActionBar().setTitle(R.string.menu_load_apks);
}
Expand Down Expand Up @@ -220,20 +223,19 @@ public void onBackPressed() {
if (drawer.isDrawerOpen(GravityCompat.START)) {
drawer.closeDrawer(GravityCompat.START);
} else if (fragment != null && fragment.isVisible()) {
if(backPressedOnce){
if (backPressedOnce) {
finish();
}
if(!backPressedOnce)
Toast.makeText(this, "Tap back once more to exit.", Toast.LENGTH_SHORT).show();
backPressedOnce=true;
new Handler().postDelayed(new Runnable()
{
if (!backPressedOnce)
Toast.makeText(this, R.string.tap_to_exit, Toast.LENGTH_SHORT).show();
backPressedOnce = true;
runnable = new Runnable() {
@Override
public void run()
{
backPressedOnce= false;
public void run() {
backPressedOnce = false;
}
}, 2000);
};
handler.postDelayed(runnable, timer);
} else {
fragmentManager.beginTransaction().setTransition(FragmentTransaction.TRANSIT_FRAGMENT_FADE)
.replace(R.id.container, new HomeFragment(), FRAGMENT_TAG_HOME).commit();
Expand All @@ -243,6 +245,15 @@ public void run()
navigationView.setCheckedItem(R.id.nav_home);
}
}

@Override
protected void onDestroy() {
super.onDestroy();
if (handler != null) {
handler.removeCallbacks(runnable);
}
}

}


Expand Down
1 change: 1 addition & 0 deletions source-code/app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<string name="menu_home">Home</string>
<string name="buildmlearn_welcome_title">Welcome to BuildmLearn Toolkit</string>
<string name="welcome">Welcome</string>
<string name="tap_to_exit">Tap back once more to exit.</string>

<!--Snackbar-->
<string name="snackbar_deleted_message">Item deleted</string>
Expand Down