Spanish language support added #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saketkumar
changed the title
|
Hey @saketkumar95 , are you confident with your translation? Is this performed using any google translator ? |
|
Yes i'm confident with the translations. I have cross checked it 2-3 times using many google translator. |
|
@opticod I'm having some problem with this branch and want to remove. What's the status for this PR? |
|
@saketkumar95 I am waiting for the notification from @croozeus |
|
Google translations is not the correct way of doing this. They are good for a start but to merge into master - we'll need couple of native spanish speakers to review this. Moreover, at a project level - I think the best way to do translations is to use a crowdsourced service - I'll look more into it this month. Closing this for now. |
|
Cool. No problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the support for Spanish Language #169 . Please Check it.