Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L200 up to 6.2.1.6 #37

Merged
merged 81 commits into from
Oct 23, 2020
Merged

L200 up to 6.2.1.6 #37

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
20ec678
feat(L200): add envelope roof tests
macintoshpie Sep 14, 2020
c2cfa4e
feat(L200): add envelope wall tests
macintoshpie Sep 14, 2020
b98ee18
feat(L200): add envelope fenestration tests
macintoshpie Sep 15, 2020
ec6509d
feat(L200): add foundation system tests
macintoshpie Sep 15, 2020
64210c4
feat(L200): add tightness tests
macintoshpie Sep 15, 2020
355272e
fix(exemplary): fix MMBtu units for NG ResourceUse
macintoshpie Sep 17, 2020
583e82e
feat(L200): test HVAC systems year installed
macintoshpie Sep 17, 2020
0cb1a35
feat(L200): add capacity and condition tests
macintoshpie Sep 18, 2020
11b5f74
feat(L200): add central plant tests
macintoshpie Sep 18, 2020
8a07c2e
feat(L200): add air distribution tests
macintoshpie Sep 22, 2020
fcb1d48
feat(L200): add outdoor air delivery tests
macintoshpie Sep 22, 2020
8bc4759
feat(L200): add duct condition tests
macintoshpie Sep 22, 2020
7f3f6e2
feat(L200): add plant pump tests
macintoshpie Sep 23, 2020
90456bc
feat(L200): add hvac controls tests
macintoshpie Sep 23, 2020
ae07352
feat(L200): add hvac zone controls test
macintoshpie Sep 23, 2020
89821b3
feat(L200): add BAS tests
macintoshpie Sep 23, 2020
dd42891
feat(L200): tie up remaining HVAC loose ends
macintoshpie Sep 23, 2020
705fe6c
feat(L200): break out EnvelopeSystems test
corymosiman12 Sep 24, 2020
2d791ae
feat(L200): EnvelopeSystems - add test to check Whole Building sectio…
corymosiman12 Sep 24, 2020
ab7af1e
feat(L200): EnvelopeSystems - add test to check a Roof exists as part…
corymosiman12 Sep 24, 2020
a3031f4
feat(L200): EnvelopeSystem - ensure warning fired for each auc:Side n…
corymosiman12 Sep 24, 2020
144bafc
feat(L200): EnvelopeSystem - add assertion if auc:Side has no auc:Wall
corymosiman12 Sep 24, 2020
9d181f2
feat(L200): EnvelopeSystem - ensure foundation exists under section w…
corymosiman12 Sep 24, 2020
daeaf8f
refactor(L200): add predicate for selecting external doors
macintoshpie Sep 24, 2020
20423b9
feat(L200): add excluded section id tests
macintoshpie Sep 24, 2020
3ca7b50
feat(L200): add utility billpayer test
macintoshpie Sep 24, 2020
2f3b068
feat(L200): add occupancy schedule test
macintoshpie Sep 24, 2020
63723ad
feat(L200): add HVAC schedule tests
macintoshpie Sep 24, 2020
5cdcd9b
feat(L200): test overall door to wall ratio
macintoshpie Sep 24, 2020
75f250b
feat(L200): DHW system type
macintoshpie Sep 25, 2020
84091df
feat(L200): add operating conditions and general condition tests
macintoshpie Sep 25, 2020
b4b0914
feat(L200): add lighting tests
macintoshpie Sep 25, 2020
c720a9d
feat(L200): add load and conveyance tests
macintoshpie Sep 25, 2020
6bfcc84
feat(L200): copy L100 historical monthly energy use
macintoshpie Sep 25, 2020
4861065
feat(L200): add peak type test
macintoshpie Sep 25, 2020
bb18b4d
feat(L200): add elec load factor test
macintoshpie Sep 25, 2020
fda4b78
feat(L200): add submetering test
macintoshpie Sep 25, 2020
5460a9e
feat(L200): add initial EEM tests
macintoshpie Sep 25, 2020
fe8eecb
feat(L200): Update IntervalDuration to match dates; Update LoadFactor…
corymosiman12 Sep 28, 2020
f3f4b96
chore: address pr comments on example bsync files
macintoshpie Sep 30, 2020
7b064b5
refactor(L200): don't require Central fan to be linked to duct system
macintoshpie Sep 30, 2020
ba273fc
feat(L200): finish Measure requirements
macintoshpie Sep 30, 2020
20f3e2f
feat(L200): finish EEM tests
macintoshpie Sep 30, 2020
94e2a78
feat(L200): test heating and cooling sources
macintoshpie Sep 30, 2020
484ea72
feat(L200): add checks for heating and cooling source tests
macintoshpie Oct 1, 2020
d5c3ec7
fix(L200): if AirSideEconomizer=None must include EconomizerControl
macintoshpie Oct 2, 2020
a5279af
fix(L200): require Central fan to be linked to Duct
macintoshpie Oct 8, 2020
95ae962
feat(L200): add Section linked System requirements
macintoshpie Oct 8, 2020
91f6824
feat(L200): add submeter requirements
macintoshpie Oct 8, 2020
296b1d6
refactor(L200): add more submeter examples
macintoshpie Oct 8, 2020
6d72a05
Merge branch 'develop' into feat/L200-6.2.1.6
macintoshpie Oct 9, 2020
f8621eb
feat(L200): add capacity requirements for condenser plants
macintoshpie Oct 9, 2020
6d3a4d9
refactor(L200): change plant requirement from output capacity to capa…
macintoshpie Oct 9, 2020
0a83394
feat(L200): require lighting systems to be linked to schedule
macintoshpie Oct 9, 2020
c9f0959
feat(L200): require scenarios linked to building
macintoshpie Oct 13, 2020
ab6c31b
feat: add clean_all arg to CLI tool; enable consistent xml file forma…
corymosiman12 Oct 15, 2020
a4e1cc4
style: run cleanup
corymosiman12 Oct 15, 2020
af97fac
fix: add back content to deleted file, tests passing
corymosiman12 Oct 15, 2020
5197247
fix: doctype declaration in generate_sch function
corymosiman12 Oct 15, 2020
0033e68
refactor(tools): add clean_file to pre-commit
macintoshpie Oct 15, 2020
3ae85f7
chore: delete empty example xml file
macintoshpie Oct 15, 2020
f8dcab0
refactor: add pre-commit to tox
macintoshpie Oct 15, 2020
7159c48
style: fix for pre-commit
macintoshpie Oct 15, 2020
f71903c
Merge pull request #49 from BuildingSync/feat/xml-file-clean
corymosiman12 Oct 15, 2020
66d147c
Merge branch 'develop' into feat/L200-6.2.1.6
corymosiman12 Oct 19, 2020
803b643
Merge branch 'develop' into feat/L200-6.2.1.6
corymosiman12 Oct 19, 2020
1339ae2
style: run clean_all
corymosiman12 Oct 19, 2020
0da60a8
fix: update XSD to v2.2.0 in L200 file
corymosiman12 Oct 19, 2020
af8c8dd
feat(eems): update L200 file measures
corymosiman12 Oct 19, 2020
69e1c2f
fix: remove requirement that every window and door must be linked to …
corymosiman12 Oct 19, 2020
3c5ab04
text(fix): envelope tests passing
corymosiman12 Oct 19, 2020
2b65b4a
Merge pull request #51 from BuildingSync/feat/eems
macintoshpie Oct 20, 2020
a99187d
feat(L200): add AnnualHeatingEfficiency reqs
macintoshpie Oct 21, 2020
ffa31a1
refactor(L200): dont require Capacity for Delivery
macintoshpie Oct 21, 2020
b0bb041
refactor(L200)!: generalize linked delivery for all CentralAirDistrib…
macintoshpie Oct 21, 2020
2cbc6ac
refactor(L200)!: require AnnualFuelUse for submeters
macintoshpie Oct 21, 2020
baedd9e
refactor(L200): change Delivery requirement to XOR
macintoshpie Oct 21, 2020
06c85b5
fix(L200): fix section type in exemplary file
macintoshpie Oct 23, 2020
ca9a4ca
refactor(L200): update fan and pump requirements
macintoshpie Oct 23, 2020
6e234e8
refactor(L200): update section system requirements
macintoshpie Oct 23, 2020
4fb1834
fix(L200): fix exemplary file DHW
macintoshpie Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion schematron/v2.2.0/exemplary_files/L100_Audit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@
--------------
Notes on any irregularities in meter readings
</auc:ResourceUseNotes>
<auc:ResourceUnits>MMbtu</auc:ResourceUnits>
<auc:ResourceUnits>MMBtu</auc:ResourceUnits>
<auc:EndUse>All end uses</auc:EndUse>
<auc:AnnualFuelUseNativeUnits>0.22</auc:AnnualFuelUseNativeUnits>
<auc:AnnualFuelUseConsistentUnits>0.22</auc:AnnualFuelUseConsistentUnits>
Expand Down
300 changes: 297 additions & 3 deletions schematron/v2.2.0/exemplary_files/L200_Audit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
for a Level 2 audit.
-->
<auc:BuildingSync xmlns:auc="http://buildingsync.net/schemas/bedes-auc/2019"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://buildingsync.net/schemas/bedes-auc/2019 https://raw.githubusercontent.com/BuildingSync/schema/develop/BuildingSync.xsd" version="2.2.0">
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://buildingsync.net/schemas/bedes-auc/2019 https://raw.githubusercontent.com/BuildingSync/schema/develop/BuildingSync.xsd" version="2.2.0-pr1">
<auc:Facilities>
<auc:Facility ID="Facility-A">
<auc:Sites>
Expand Down Expand Up @@ -78,6 +78,8 @@
<auc:ConditionedFloorsAboveGrade>1</auc:ConditionedFloorsAboveGrade>
<auc:ConditionedFloorsBelowGrade>1</auc:ConditionedFloorsBelowGrade>

<auc:BuildingAutomationSystem>true</auc:BuildingAutomationSystem>

<!-- 6.1.1.2.b -->
<auc:HistoricalLandmark>true</auc:HistoricalLandmark>

Expand All @@ -93,6 +95,10 @@
</auc:FloorArea>
</auc:FloorAreas>

<auc:TotalExteriorAboveGradeWallArea>123</auc:TotalExteriorAboveGradeWallArea>
<auc:TotalExteriorBelowGradeWallArea>123</auc:TotalExteriorBelowGradeWallArea>
<auc:OverallWindowToWallRatio>0.2</auc:OverallWindowToWallRatio>

macintoshpie marked this conversation as resolved.
Show resolved Hide resolved
<!-- 6.1.1.1.i -->
<auc:YearOfConstruction>1993</auc:YearOfConstruction>
<!-- 6.1.1.1.l (recommended) -->
Expand Down Expand Up @@ -144,6 +150,101 @@
</auc:FloorArea>

</auc:FloorAreas>
<auc:ThermalZoneLayout>Single zone</auc:ThermalZoneLayout>
</auc:Section>

<auc:Section ID="Section-Whole-building">
<auc:SectionType>Whole building</auc:SectionType>
<auc:FootprintShape>Rectangular</auc:FootprintShape>
<auc:Sides>
<auc:Side>
<auc:SideNumber>A1</auc:SideNumber>
<auc:WallIDs>
<auc:WallID IDref="Wall-A">
<auc:WallArea>123</auc:WallArea>
</auc:WallID>
</auc:WallIDs>
<auc:WindowIDs>
<auc:WindowID IDref="Window-A">
<auc:FenestrationArea>123</auc:FenestrationArea>
</auc:WindowID>
</auc:WindowIDs>
<auc:DoorIDs>
<auc:DoorID IDref="Door-A">
<auc:FenestrationArea>123</auc:FenestrationArea>
</auc:DoorID>
</auc:DoorIDs>
</auc:Side>
<auc:Side>
<auc:SideNumber>B1</auc:SideNumber>
<auc:WallIDs>
<auc:WallID IDref="Wall-A">
<auc:WallArea>123</auc:WallArea>
</auc:WallID>
</auc:WallIDs>
<auc:WindowIDs>
<auc:WindowID IDref="Window-A">
<auc:FenestrationArea>123</auc:FenestrationArea>
</auc:WindowID>
</auc:WindowIDs>
<auc:DoorIDs>
<auc:DoorID IDref="Door-A">
<auc:FenestrationArea>123</auc:FenestrationArea>
</auc:DoorID>
</auc:DoorIDs>
</auc:Side>
<auc:Side>
<auc:SideNumber>C1</auc:SideNumber>
<auc:WallIDs>
<auc:WallID IDref="Wall-A">
<auc:WallArea>123</auc:WallArea>
</auc:WallID>
</auc:WallIDs>
<auc:WindowIDs>
<auc:WindowID IDref="Window-A">
<auc:FenestrationArea>123</auc:FenestrationArea>
</auc:WindowID>
</auc:WindowIDs>
<auc:DoorIDs>
<auc:DoorID IDref="Door-A">
<auc:FenestrationArea>123</auc:FenestrationArea>
</auc:DoorID>
</auc:DoorIDs>
</auc:Side>
<auc:Side>
<auc:SideNumber>D1</auc:SideNumber>
<auc:WallIDs>
<auc:WallID IDref="Wall-A">
<auc:WallArea>123</auc:WallArea>
</auc:WallID>
</auc:WallIDs>
<auc:WindowIDs>
<auc:WindowID IDref="Window-A">
<auc:FenestrationArea>123</auc:FenestrationArea>
</auc:WindowID>
</auc:WindowIDs>
<auc:DoorIDs>
<auc:DoorID IDref="Door-A">
<auc:FenestrationArea>123</auc:FenestrationArea>
</auc:DoorID>
</auc:DoorIDs>
</auc:Side>
</auc:Sides>
<auc:Roofs>
<auc:Roof>
<auc:RoofID IDref="Roof-A">
<auc:RoofArea>123</auc:RoofArea>
<auc:RoofCondition>Excellent</auc:RoofCondition>
</auc:RoofID>
</auc:Roof>
</auc:Roofs>
<auc:Foundations>
<auc:Foundation>
<auc:FoundationID IDref="Foundation-A">
<auc:FoundationArea>123</auc:FoundationArea>
</auc:FoundationID>
</auc:Foundation>
</auc:Foundations>
</auc:Section>
</auc:Sections>

Expand All @@ -157,7 +258,99 @@
<auc:HVACSystems>
<!-- 6.1.1.1.g/5.3.4.g (for every space function) -->
<auc:HVACSystem ID="HVAC-A">
<auc:PrincipalHVACSystemType>Packaged Terminal Air Conditioner</auc:PrincipalHVACSystemType>
<auc:Plants>
<auc:CoolingPlants>
<auc:CoolingPlant ID="CoolingPlant-A">
<auc:DistrictChilledWater>
<auc:AnnualCoolingEfficiencyValue>123</auc:AnnualCoolingEfficiencyValue>
<auc:AnnualCoolingEfficiencyUnits>COP</auc:AnnualCoolingEfficiencyUnits>
<auc:Capacity>123</auc:Capacity>
<auc:CapacityUnits>gpm</auc:CapacityUnits>
</auc:DistrictChilledWater>
<auc:CoolingPlantCondition>Good</auc:CoolingPlantCondition>
<auc:YearInstalled>2020</auc:YearInstalled>
<auc:PrimaryFuel>Other</auc:PrimaryFuel>
<auc:BuildingAutomationSystem>true</auc:BuildingAutomationSystem>
<auc:ControlSystemTypes>
<auc:ControlSystemType>
<auc:Digital></auc:Digital>
</auc:ControlSystemType>
</auc:ControlSystemTypes>
</auc:CoolingPlant>
</auc:CoolingPlants>
</auc:Plants>
<auc:HeatingAndCoolingSystems>
<auc:ZoningSystemType>Single zone</auc:ZoningSystemType>
<auc:HeatingSources>
<auc:HeatingSource ID="HeatingSource-A">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey ted - idk how this slipped the radar until now, but I would say we also need to add checks for the following.

An auc:HeatingSource should have the following:

  • count(auc:HeatingSourceType/*) = 1
  • For auc:HeatingSourceType/auc:Furnace:
    • auc:FurnaceType
  • For auc:HeatingSourceType/auc:HeatPump:
    • auc:HeatPumpType
    • auc:HeatPumpBackupSystemFuel

An auc:CoolingSource should have the following:

  • count(auc:CoolingSourceType/*) = 1
  • For auc:CoolingSourceType/auc:DX:
    • auc:DXSystemType
    • auc:CompressorType
    • auc:CompressorStaging
  • For auc:EvaporativeCooler:
    • auc:EvaporativeCoolingType

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corymosiman12 are this for all heating/cooling sources, or only for those that don't reference a heating/cooling plant?

E.g. we currently have special requirements for auc:HeatingSources/auc:HeatingSource[not(auc:HeatingSourceType/auc:HeatingPlantID)] (same for cooling)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would narrate the checks as follows for a auc:HeatingSource (mirror for auc:CoolingSource):

  • There must be an auc:HeatingSourceType defined
  • For a heating source which is an auc:Furnance, it must define the auc:FurnaceType
    ... etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goof, Heating/CoolingPlantID are choices for Heating/CoolingSourceType. I'll add these tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed here: 94e2a78

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to 211 spreadsheet as well under 6.2.1.3.a.1 0: Identify the System type

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @macintoshpie, just added a few new things here:

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed here a99187d

<auc:InputCapacity>123</auc:InputCapacity>
<auc:OutputCapacity>123</auc:OutputCapacity>
<auc:CapacityUnits>gpm</auc:CapacityUnits>
<auc:HeatingSourceCondition>Good</auc:HeatingSourceCondition>
<auc:Controls>
<auc:Control>
<auc:OtherControlTechnology>
<auc:ControlSystemType>
<auc:Digital></auc:Digital>
</auc:ControlSystemType>
</auc:OtherControlTechnology>
</auc:Control>
</auc:Controls>
<auc:YearInstalled>2020</auc:YearInstalled>
</auc:HeatingSource>
</auc:HeatingSources>
<auc:CoolingSources>
<auc:CoolingSource ID="CoolingSource-A">
<auc:CoolingSourceType>
<auc:CoolingPlantID IDref="CoolingPlant-A" />
</auc:CoolingSourceType>
</auc:CoolingSource>
</auc:CoolingSources>
<auc:Deliveries>
<auc:Delivery ID="Delivery-A">
<auc:DeliveryType>
<auc:CentralAirDistribution>
<auc:AirDeliveryType>Central fan</auc:AirDeliveryType>
<auc:TerminalUnit>CAV terminal box no reheat</auc:TerminalUnit>
<auc:ReheatSource>None</auc:ReheatSource>
<auc:FanBased>
<auc:AirSideEconomizer ID="AirSideEconomizer-A">
<auc:AirSideEconomizerType>None</auc:AirSideEconomizerType>
<auc:EconomizerControl>Fixed</auc:EconomizerControl>
</auc:AirSideEconomizer>
</auc:FanBased>
</auc:CentralAirDistribution>
</auc:DeliveryType>
<auc:HeatingSourceID IDref="HeatingSource-A" />
<auc:CoolingSourceID IDref="CoolingSource-A" />
<auc:Capacity>123</auc:Capacity>
Copy link
Contributor

@corymosiman12 corymosiman12 Sep 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nllong when we declare the capacity of an auc:Delivery separately from the auc:CoolingSource and auc:HeatingSource, what does that mean? Is that non-sensical? Should an auc:Delivery not declare an auc:Capacity, since the heating capacity is provided by the auc:HeatingSource and the cooling capacity is provided by the auc:CoolingSource?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would the capacity of a auc:Delivery be? Could that be the total design CFM? This does seem strange.

Copy link
Contributor

@corymosiman12 corymosiman12 Oct 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macintoshpie

  1. Remove requirement of auc:Capacity and auc:CapacityUnits on a Delivery system for the schematron.
  2. Begin deprecation of these elements for the auc:Delivery.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed here ffa31a1

<auc:CapacityUnits>gpm</auc:CapacityUnits>
<auc:Controls>
<auc:Control>
<auc:OtherControlTechnology>
<auc:ControlSystemType>
<auc:Digital></auc:Digital>
</auc:ControlSystemType>
</auc:OtherControlTechnology>
</auc:Control>
</auc:Controls>
<auc:YearInstalled>2020</auc:YearInstalled>
<auc:Quantity>1</auc:Quantity>
<auc:DeliveryCondition>Good</auc:DeliveryCondition>
</auc:Delivery>
</auc:Deliveries>
</auc:HeatingAndCoolingSystems>
<auc:DuctSystems>
<auc:DuctSystem ID="DuctSystem-A">
<auc:DuctConfiguration>Single</auc:DuctConfiguration>
<auc:DuctInsulationCondition>Excellent</auc:DuctInsulationCondition>
<auc:HeatingDeliveryID IDref="Delivery-A" />
</auc:DuctSystem>
</auc:DuctSystems>
<auc:PrincipalHVACSystemType>Packaged Rooftop VAV with Hot Water Reheat</auc:PrincipalHVACSystemType>
macintoshpie marked this conversation as resolved.
Show resolved Hide resolved
<auc:HVACControlSystemTypes>
<auc:HVACControlSystemType>Digital</auc:HVACControlSystemType>
</auc:HVACControlSystemTypes>
<auc:LinkedPremises>
<auc:Section>
<auc:LinkedSectionID IDref="Section-Space-A"></auc:LinkedSectionID>
Expand All @@ -184,6 +377,81 @@
</auc:LightingSystem>
</auc:LightingSystems>

<auc:PumpSystems>
<auc:PumpSystem ID="PumpSystem-A">
<auc:PumpControlType>Constant Volume</auc:PumpControlType>
<auc:LinkedSystemIDs>
<auc:LinkedSystemID IDref="HeatingPlant-A" />
</auc:LinkedSystemIDs>
</auc:PumpSystem>
<auc:PumpSystem ID="PumpSystem-B">
<auc:PumpControlType>Constant Volume</auc:PumpControlType>
macintoshpie marked this conversation as resolved.
Show resolved Hide resolved
<auc:LinkedSystemIDs>
<auc:LinkedSystemID IDref="CoolingPlant-A" />
</auc:LinkedSystemIDs>
</auc:PumpSystem>
</auc:PumpSystems>

<auc:FanSystems>
<auc:FanSystem ID="FanSystem-A">
<auc:FanControlType>Stepped</auc:FanControlType>
<auc:LinkedSystemIDs>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For fans, I think we should also require:

  • FanEfficiency
  • FanSize
  • InstalledFlowRate [WARNING]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a PR to the schema to:

  • deprecate FanSize
  • Add FanMaximumFlowRate (to mirror the pump). This is replacing FanSize. Assuming that gets approved, change the above to require FanMaximumFlowRate instead of FanSize

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, to mirror pump, change InstalledFlowRate -> FanInstalledFlowRate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First part addressed here: ca9a4ca

I think we should punt on adding these new elements for now and just get this PR merged, then tweak as we need to later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kk

<auc:LinkedSystemID IDref="Delivery-A" />
</auc:LinkedSystemIDs>
</auc:FanSystem>
</auc:FanSystems>

<auc:WallSystems>
<auc:WallSystem ID="Wall-A">
<auc:ExteriorWallConstruction>Concrete poured</auc:ExteriorWallConstruction>
<auc:WallRValue>1</auc:WallRValue>
</auc:WallSystem>
</auc:WallSystems>

<auc:RoofSystems>
<auc:RoofSystem ID="Roof-A">
<auc:RoofConstruction>Wood frame</auc:RoofConstruction>
<auc:RoofRValue>1</auc:RoofRValue>
</auc:RoofSystem>
</auc:RoofSystems>

<auc:FenestrationSystems>
<auc:FenestrationSystem ID="Window-A">
<auc:FenestrationType>
<auc:Window></auc:Window>
</auc:FenestrationType>
<auc:FenestrationFrameMaterial>Steel</auc:FenestrationFrameMaterial>
<auc:GlassType>Low e</auc:GlassType>
<auc:FenestrationGlassLayers>Single pane</auc:FenestrationGlassLayers>
<auc:FenestrationRValue>0.5</auc:FenestrationRValue>
<auc:SolarHeatGainCoefficient>0.5</auc:SolarHeatGainCoefficient>
<auc:VisibleTransmittance>0.5</auc:VisibleTransmittance>
</auc:FenestrationSystem>
<auc:FenestrationSystem ID="Door-A">
<auc:FenestrationType>
<auc:Door>
<auc:ExteriorDoorType>Insulated metal</auc:ExteriorDoorType>
<auc:DoorGlazedAreaFraction>0.5</auc:DoorGlazedAreaFraction>
</auc:Door>
</auc:FenestrationType>
<auc:FenestrationFrameMaterial>Steel</auc:FenestrationFrameMaterial>
<auc:FenestrationRValue>0.5</auc:FenestrationRValue>
</auc:FenestrationSystem>
</auc:FenestrationSystems>

<auc:FoundationSystems>
<auc:FoundationSystem ID="Foundation-A">
<auc:GroundCouplings>
<auc:GroundCoupling>
<auc:SlabOnGrade>
<auc:SlabUFactor>0.5</auc:SlabUFactor>
</auc:SlabOnGrade>
</auc:GroundCoupling>
</auc:GroundCouplings>
<auc:FloorConstructionType>Concrete poured</auc:FloorConstructionType>
</auc:FoundationSystem>
</auc:FoundationSystems>

<auc:PlugLoads>
<!-- 6.1.1.1.g/5.3.4.e (for every space function) -->
<auc:PlugLoad ID="PlugLoad-A">
Expand Down Expand Up @@ -234,6 +502,32 @@
<auc:CapacityUnits>kW</auc:CapacityUnits>
</auc:OnsiteStorageTransmissionGenerationSystem>
</auc:OnsiteStorageTransmissionGenerationSystems>

<auc:AirInfiltrationSystems>
<auc:AirInfiltrationSystem ID="AirInfiltration-A">
<auc:AirInfiltrationNotes>Notes on the test conducted</auc:AirInfiltrationNotes>
<auc:Tightness>Very Tight</auc:Tightness>
<auc:AirInfiltrationValue>123</auc:AirInfiltrationValue>
<auc:AirInfiltrationValueUnits>CFM25</auc:AirInfiltrationValueUnits>
<auc:AirInfiltrationTest>Blower door</auc:AirInfiltrationTest>
<auc:LinkedPremises>
<auc:Section>
<auc:LinkedSectionID IDref="Section-Whole-building"></auc:LinkedSectionID>
</auc:Section>
</auc:LinkedPremises>
</auc:AirInfiltrationSystem>
</auc:AirInfiltrationSystems>

<auc:WaterInfiltrationSystems>
<auc:WaterInfiltrationSystem>
<auc:WaterInfiltrationNotes>Notes on the test conducted</auc:WaterInfiltrationNotes>
<auc:LinkedPremises>
<auc:Section>
<auc:LinkedSectionID IDref="Section-Whole-building"></auc:LinkedSectionID>
</auc:Section>
</auc:LinkedPremises>
</auc:WaterInfiltrationSystem>
</auc:WaterInfiltrationSystems>
</auc:Systems>

<auc:Schedules>
Expand Down Expand Up @@ -452,7 +746,7 @@
--------------
Notes on any irregularities in meter readings
</auc:ResourceUseNotes>
<auc:ResourceUnits>MMbtu</auc:ResourceUnits>
<auc:ResourceUnits>MMBtu</auc:ResourceUnits>
<auc:EndUse>All end uses</auc:EndUse>
<auc:AnnualFuelUseNativeUnits>0.22</auc:AnnualFuelUseNativeUnits>
<auc:AnnualFuelUseConsistentUnits>0.22</auc:AnnualFuelUseConsistentUnits>
Expand Down
Loading