fix: add width caculate #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/store/useGlobalStore.ts
huangbinjie
reviewed
Apr 17, 2024
src/content/index.tsx
Outdated
Comment on lines
39
to
42
| useGlobalStore.setState({ | ||
| drawerWidth: caculateDrawerWidth(), | ||
| backWidth: caculateBackWidth(), | ||
| }); |
There was a problem hiding this comment.
之前的计算频率是在onload onresize两个事件触发的时候进行计算。但是onresize不会经常被触发，除非用户手动调整窗口。onload要基于twitter全部加载完成，有时候时间很长，要30秒。其次是还有很多时候用户切换到其他页面等等因素，这两个时机是不够的，因此加入到全局的计算中去。定时计算宽度，如果宽度不变，我认为性能损耗是不高的。
There was a problem hiding this comment.
我测试了下，宽度不变定时去 set 也会导致 rerender。而且因为是根节点和到处都用的全局 store，导致整个插件定时的 rerender。感觉 onLoad 够用了，长点的话插件有最小宽度保底问题不大
huangbinjie
reviewed
Apr 17, 2024
src/store/useGlobalStore.ts
Outdated
Comment on lines
27
to
28
| drawerWidth: number; | ||
| backWidth: number; |
There was a problem hiding this comment.
主要是想把定时任务的代码都收拢到/content/index.ts中去方便管理。然后宽度这个东西勉强算个全局变量吧，描述的是整体的宽度
There was a problem hiding this comment.
你放到 drawer/index.tsx 里面更适合，不然你定时去 setInterval 会导致所有组件都会定时去 rerender
huangbinjie
reviewed
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.