add color to selected date on daySelectionAnimation for background inversion #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peacechen
reviewed
Dec 24, 2020
| @@ -27,6 +28,7 @@ interface IDaySelectionAnimationBackground { | |||
| animUpdateType: any; | |||
| animProperty: any; | |||
| animSpringDamping: any; | |||
| color: 'string'; | |||
There was a problem hiding this comment.
Please change to double quotes for consistency
peacechen
reviewed
Dec 24, 2020
| @@ -55,6 +55,7 @@ class CalendarDay extends Component { | |||
| borderWidth: 1, | |||
| borderHighlightColor: "black", | |||
| highlightColor: "yellow", | |||
| color: '#fff', | |||
There was a problem hiding this comment.
Please change to double quotes for consistency
|
Thanks @bilalesi for this useful PR. I made some comments regarding double quotes. Please also add the color field to the Readme. |
|
This is obsoleted by #248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add color to daySelectionAnimation when choosing background color,
it's not always that the black color make a good reflexion for the background color when selecting a date
so it must be ass a color to the text of the container