Rediseño Navbar #211

ortega-pablo · 2024-02-29T16:12:05Z

Desarrollo de nuevo NavBar y NavBar usuarios

…into navbar

Navbar - ETI-89 - ETI-87

thehighestprimenumber

resolver conflictos
resolver las decenas de warnings que tira la consola al ejecutarlo
tenemos demasiados botones y componentes, todos con estilado especial, escrito inline.Lo que hay que hacer es crear componentes propios que sean "CallToActionButton", "SecondaryButton", "CenteredBox", etc. que tengan un significado semantico dentro del Design System. Les recomiendo que investiguen un poco sobre qué es y cómo implementar un Design System

Además les enviaremos un documento con bugs visuales.

thehighestprimenumber · 2024-02-29T17:52:55Z

public/locales/es/bar.json

@@ -1,13 +1,18 @@
 {
  "history": "Historia del ETI",
-  "manifest": "Manifiesto ETIano",
-  "signup": "Inscripción",
+  "manifest": "Manifiesto Etiano",


Hola, por favor no cambien los nombres de las cosas que ya teníamos. es ETIano, el botón es "Crear Usuario / Ingresar", etc

thehighestprimenumber · 2024-02-29T17:53:11Z

public/locales/es/user.json

@@ -1,8 +1,9 @@
 {
-  "myProfile": "Mis datos personales",
+  "myProfile": "Mis datos",


Lo mismo, porfa no cambien los textos que ya definimos nosotrxs

Se dejó "Mis datos" porque era parte del diseño preaprobado y adicionar personales incorporaría una línea al botón del menú

thehighestprimenumber · 2024-02-29T18:09:30Z

src/components/EtiAppBar.js

+                    >
+                      {userData.nameFirst?.split(' ')[0]} {userData.nameLast?.split(' ')[0]}
+                    </Typography>
+                    {userData?.roles?.[UserRoles.SUPER_ADMIN] && (


usar la función isSuperAdmin

No se puede utilizar la función isSuperadmin ya que el contexto de usuario no llega a EtiAppBar.js y el tipo de dato es distinto al requerir el usuario directamente de firebase

thehighestprimenumber · 2024-02-29T18:09:35Z

src/components/EtiAppBar.js

+                  <Stack direction="column" sx={{ height: 20, mt: '5px', mr: '5px' }}>
+                    <Typography
+                      variant="workSansFont"
+                      sx={!userData?.roles || userData?.roles?.admin ? { mt: 1.5 } : {}}


usar la función isAdmin

es el item 8 en las buenas practica,s usé exactamente este ejemplo

https://opaque-doll-bb3.notion.site/Buenas-Pr-cticas-50da62b4aedb40f9b4f9e07dba1b6e5a#:~:text=Busca%20o%20crea%20funciones%20compartidas%20para%20funcionalidades%20repetidas%20(ej%3A%20para%20verificar%20si%20un%20usuario%20es%20admin%2C%20usar%20la%20funcion%20isAdmin(user)%20en%20lugar%20de%20chequear%20sus%20propiedades%20%E2%80%9Ca%20mano%E2%80%9D.

No se puede utilizar la función isSuperadmin ya que el contexto de usuario no llega a EtiAppBar.js y el tipo de dato es distinto al requerir el usuario directamente de firebase

thehighestprimenumber · 2024-02-29T18:12:48Z

src/components/EtiAppBar.js

+
+          <Box
+            sx={{
+              display: {


por favoro no quitar las aria-.... El ETI es un evento inclusivo y aspiramos a que el sitio sea accesible

Incorporadas nuevamente

thehighestprimenumber · 2024-02-29T18:22:47Z

src/modules/user/components/menu/userMenu.jsx

+            {userIsSuperAdmin &&
+              <ListItemButton onClick={() => { handleListItemClick(2), toggleOpen() }} sx={{
+                ...itemButtonStyle,
+                ...(selectedIndex === 2 && itemButtonActiveStyle),


evitar usar númemeros hardcodeados... qué significa ese 2 en este contexto?

Se colocaron nombre a los elementos para no utilizar los números harcodeados

thehighestprimenumber · 2024-02-29T18:25:54Z

src/modules/user/components/navBar/UserNavBar.tsx

+        <Box sx={{ height: '50px' }}>
+          <Stack direction="column" sx={{ height: 20, mt: '5px' }}>
+            <Typography variant="h6" color= 'listItems.light' sx={{ fontWeight: 600 }}>
+              {userData.nameFirst?.split(' ')[0]} {userData.nameLast?.split(' ')[0]}


esta lógica la vi en otro lado, deberríamos tener una función compartida que reciba el userData y nos devuelva el nombre formateado

Se incorporó una función en el userData para manejar esta funcionalidad

thehighestprimenumber · 2024-02-29T18:26:02Z

src/modules/user/components/navBar/UserNavBar.tsx

+            <Typography variant="h6" color= 'listItems.light' sx={{ fontWeight: 600 }}>
+              {userData.nameFirst?.split(' ')[0]} {userData.nameLast?.split(' ')[0]}
+            </Typography>
+            {userData?.roles?.[UserRoles.SUPER_ADMIN] && (


usar isAdmin

No se puede utilizar la función isSuperadmin ya que el contexto de usuario no llega a UserNavBar.js y el tipo de dato es distinto al requerir el usuario directamente de firebase

thehighestprimenumber · 2024-02-29T18:26:45Z

src/modules/user/components/navBar/UserNavBar.tsx

+          <Box>
+            <Button
+              onClick={() => {
+                navigate('/sign-in');


usar ROUTES.SIGN_IN

Implementado

thehighestprimenumber · 2024-02-29T18:29:11Z

src/modules/user/components/menu/userMenu.jsx

+            )}
+
+
+            <ListItemButton onClick={() => { handleClickInscriptions(), handleListItemClick(dropDownInscriptions) }} sx={{


parece que tenemos este mismo elemento o uno muy parecido varias veces por el código, sería bueno pulirlo un poco y que sea más facil de usar.

…lines.

…into navbar

Navbar

develop merge and fix React importation

Navbar / Sidebar ETI-95

LRAlvaro and others added 21 commits February 26, 2024 22:48

feature: navbar

d7eb3ce

refactor: navbar

762ba4b

fix: name and role in all routes

4ebe93b

refactor: navbar code

b82aabf

config

2194602

side bar styles and functionalities

d8fe6df

refactor typography and color theme

2aca432

delete emulator db and config files

16d4a6a

fix: height in sidebar

cdb34da

btn signin sidebar

7ecbfce

Merge branch 'navbar' of https://github.com/mecantronic/etitango-front …

e5395aa

…into navbar

logout btn in sidebar whit no logged

cdeefa9

added hamburger menu functionality

a908bbf

refactor: translate and style code

c413c43

create pallete colors listItems sidebar

4d71532

fix: styles and superadmin

b00c55f

refactor prettier lines

1e3f13a

fixed validation superadmin

2202e2b

Update UserNavBar.tsx

d799bca

Update EtiAppBar.js

a137ef8

Merge pull request #57 from mecantronic/navbar

81e8aa1

Navbar - ETI-89 - ETI-87

thehighestprimenumber requested changes Feb 29, 2024

View reviewed changes

ortega-pablo and others added 8 commits February 29, 2024 15:42

Update userMenu.jsx

5142da0

Merge branch 'main' into delivery

72b11d1

refactor: user profile form centered and fix overlapping navbar text …

40a8ed0

…lines.

feature: new full name function and fixed ARIAS and admin, superadmin

90d4129

refactor: refactoring in multiple files

a0d14fc

Merge branch 'navbar' of https://github.com/mecantronic/etitango-front …

1d1fa19

…into navbar

refactor: styles in general information ETI.

4969070

Refactor userMenu code

64fac78

Misael-Corts and others added 15 commits March 4, 2024 20:19

Merge branch 'navbar' of https://github.com/mecantronic/etitango-front …

163d6c2

…into navbar

fix: collapse in sidebar and show options if user is not login

f77176f

delete meta-data

003af67

fix function first and name last

869b5a4

refactor userMenu style and code

73a10ee

Merge branch 'navbar' of https://github.com/mecantronic/etitango-front …

d232af2

…into navbar

fix sidebar name and button / new ETI centralized

8674505

fix: multiple styles

280fbf3

fix name function

5d20f5d

fix style in userNavBar when is mobile

320962e

refactor userMenu styles and menuItems components created

b11ca17

refactor: styles in useNavBar, EtiAppBar and packaga-lock modified

07bf90b

Merge pull request #58 from mecantronic/navbar

92abac9

Navbar

develop merge and fix React importation

938e72c

Merge pull request #59 from mecantronic/merge-main-delivery

3407a2b

develop merge and fix React importation

ortega-pablo requested a review from thehighestprimenumber March 8, 2024 16:40

Misael-Corts and others added 3 commits March 15, 2024 13:39

added new theme and replace navbar and sidebar

d0cf732

refactor: new titles styles in theme

e8beac9

Merge pull request #61 from mecantronic/navbar

ca7b544

Navbar / Sidebar ETI-95

thehighestprimenumber force-pushed the main branch from b1cfa4d to 9783b5e Compare December 21, 2024 00:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rediseño Navbar #211

Rediseño Navbar #211

ortega-pablo commented Feb 29, 2024

thehighestprimenumber left a comment

thehighestprimenumber Feb 29, 2024

ortega-pablo Mar 8, 2024

thehighestprimenumber Feb 29, 2024

ortega-pablo Mar 8, 2024

thehighestprimenumber Feb 29, 2024

ortega-pablo Mar 8, 2024

thehighestprimenumber Feb 29, 2024

thehighestprimenumber Feb 29, 2024

ortega-pablo Mar 8, 2024

thehighestprimenumber Feb 29, 2024

ortega-pablo Mar 8, 2024

thehighestprimenumber Feb 29, 2024

ortega-pablo Mar 8, 2024

thehighestprimenumber Feb 29, 2024

ortega-pablo Mar 8, 2024

thehighestprimenumber Feb 29, 2024

ortega-pablo Mar 8, 2024

thehighestprimenumber Feb 29, 2024

ortega-pablo Mar 8, 2024

thehighestprimenumber Feb 29, 2024

		)}


		<ListItemButton onClick={() => { handleClickInscriptions(), handleListItemClick(dropDownInscriptions) }} sx={{

Rediseño Navbar #211

Are you sure you want to change the base?

Rediseño Navbar #211

Conversation

ortega-pablo commented Feb 29, 2024

thehighestprimenumber left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment