Extract automation step definitions out into shared-core. #15383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
reviewed
Jan 17, 2025
| stepId: AutomationActionStepId.EXECUTE_BASH, | ||
| inputs: {}, | ||
| schema: { | ||
| inputs: { |
There was a problem hiding this comment.
Would not be enough moving inputs and outputs? Will we be using anything else in the frontend?
There was a problem hiding this comment.
cc @deanhannigan, I believe the big win from this would be testing.
adrinr
approved these changes
Jan 20, 2025
…ll-automation-definitions-into-shared-core
…f github.com:budibase/budibase into pro-279-pull-automation-definitions-into-shared-core
samwho
deleted the
pro-279-pull-automation-definitions-into-shared-core
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is so that we can make use of them in the frontend to generate data in tests.
Addresses