New RBAC UI #14577
Merged
New RBAC UI #14577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alidator not allowing the structure that roles are expected to have.
aptkingston
commented
Oct 18, 2024
| @@ -177,6 +178,7 @@ export async function save(ctx: UserCtx<SaveRoleRequest, SaveRoleResponse>) { | |||
| }, | |||
| }) | |||
| } | |||
| builderSocket?.emitRoleUpdate(ctx, role) | |||
There was a problem hiding this comment.
The only backend change is multiplayer support for role changes.
…-role Preview role - multi-inheritance fixes
deanhannigan
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
LGTM! Any issues found during testing are now resolved 🎉 . Fantastic work @aptkingston. The new role UX is amazing!
| }) | ||
| </script> | ||
|
|
||
| <div class="dev-preview-header" class:mobile={$context.device.mobile}> | ||
| <Heading size="XS">Preview</Heading> | ||
| <Heading size="XS">Previ werewr eww</Heading> |
There was a problem hiding this comment.
Thank you 😂 May have been testing things...
mike12345567
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new visual way of defining roles for your apps. Custom roles can be created, edited and deleted using this new RBAC editor, and inheritance can be defined using intuitive drag-and-drop connections. Inheriting multiple roles is now possible too.
Clarification of functionality:
Feature branch env
Feature Branch Link