Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud Storage Integration #12267

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

deanhannigan
Copy link
Contributor

@deanhannigan deanhannigan commented Nov 3, 2023

Description

Adding Google Cloud Storage support to Budibase.

Query, create and manage buckets in your Google Cloud Storage and allow users to upload new media via Budibase.

Screenshot 2023-11-03 at 09 38 28

Query Types

  • Create Bucket

  • Delete File By Key

    • Bucket Name - the name of the target bucket.
    • Delete - the key of the file to be deleted. You can hard code this or use a binding to build a dynamic delete in your application
  • Read Bucket

    • List all available media in your bucket and integrate them into your applications.
    • Bucket Name - the name of the target bucket.

Authorization

The integration currently supports Service Account authorization by JSON token; the contents of which are used to configure the datasource. The following fields are required from the token.

  • Project Id
  • Private Key
  • Client Email - the service user email.

Privileges granted to the service can be managed in the Google Cloud Console.

Addresses:

Screenshots

The Google Cloud Storage File Upload component is now available in the components list.

Screenshot 2023-11-03 at 11 15 08

The Upload File to GoogleCloud button action

Screenshot 2023-11-03 at 11 17 14

Feature branch env

Feature Branch Link

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

Attention: Patch coverage is 17.94872% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 67.42%. Comparing base (c2a82bb) to head (a43591e).
Report is 2665 commits behind head on master.

❗ Current head a43591e differs from pull request most recent head c0177aa. Consider uploading reports for the commit c0177aa to get more accurate results

Files Patch % Lines
packages/server/src/integrations/googlecloud.ts 15.38% 22 Missing ⚠️
...ackages/server/src/api/controllers/static/index.ts 16.66% 9 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12267      +/-   ##
==========================================
- Coverage   67.52%   67.42%   -0.10%     
==========================================
  Files         505      506       +1     
  Lines       20170    20206      +36     
  Branches     4176     4178       +2     
==========================================
+ Hits        13619    13624       +5     
- Misses       6056     6086      +30     
- Partials      495      496       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deanhannigan deanhannigan marked this pull request as ready for review November 6, 2023 10:19
Copy link
Collaborator

@samwho samwho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this isn't quite ready for merging yet but I'm doing a sweep of all PRs and thought I'd take a look. Hope that's okay.

Copy link
Collaborator

@melohagan melohagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, however I feel like we should try and reduce the duplicate code, actions and components, because Azure Storage can also be added: #12530

@github-actions github-actions bot added the stale label Jan 9, 2024
@melohagan melohagan removed the stale label Jan 9, 2024
@deanhannigan deanhannigan requested a review from a team as a code owner February 1, 2024 09:21
@deanhannigan deanhannigan requested review from adrinr and removed request for a team February 1, 2024 09:21
@deanhannigan
Copy link
Contributor Author

It looks good, however I feel like we should try and reduce the duplicate code, actions and components, because Azure Storage can also be added: #12530

I replaced the duplicated UI/UX with a common StoreUpload component. Both S3 and GCS use it with a type parameter to discern which cloud storage endpoint is being targeted

@shogunpurple
Copy link
Member

@deanhannigan can we move this to draft if it's not ready for review/merge?

@deanhannigan deanhannigan marked this pull request as draft July 2, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants