-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Cloud Storage Integration #12267
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #12267 +/- ##
==========================================
- Coverage 67.52% 67.42% -0.10%
==========================================
Files 505 506 +1
Lines 20170 20206 +36
Branches 4176 4178 +2
==========================================
+ Hits 13619 13624 +5
- Misses 6056 6086 +30
- Partials 495 496 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this isn't quite ready for merging yet but I'm doing a sweep of all PRs and thought I'd take a look. Hope that's okay.
packages/client/src/components/app/forms/GoogleCloudUpload.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, however I feel like we should try and reduce the duplicate code, actions and components, because Azure Storage can also be added: #12530
I replaced the duplicated UI/UX with a common |
@deanhannigan can we move this to draft if it's not ready for review/merge? |
Description
Adding Google Cloud Storage support to Budibase.
Query, create and manage buckets in your Google Cloud Storage and allow users to upload new media via Budibase.
Query Types
Create Bucket
Bucket Name
- the name of your new bucket. You will be notified if the bucket name is not uniqueLocation
- http://g.co/cloud/storage/docs/locations#location-mrStorage Class
- https://cloud.google.com/storage/docs/storage-classesPublic
(Optional) - this will provide completely unauthenticated access to the bucket. Ensure that this is the desired outcome.Delete File By Key
Bucket Name
- the name of the target bucket.Delete
- the key of the file to be deleted. You can hard code this or use a binding to build a dynamic delete in your applicationRead Bucket
Bucket Name
- the name of the target bucket.Authorization
The integration currently supports Service Account authorization by JSON token; the contents of which are used to configure the datasource. The following fields are required from the token.
Project Id
Private Key
Client Email
- the service user email.Privileges granted to the service can be managed in the Google Cloud Console.
Addresses:
Screenshots
The
Google Cloud Storage File Upload
component is now available in the components list.The
Upload File to GoogleCloud
button actionFeature branch env
Feature Branch Link