daemon/screenshot: Support uploading to web services #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshStrobl
requested review from
JoshStrobl,
EbonJaeger,
a team,
fossfreedom and
serebit
joebonrichie
force-pushed
the
screenshot-upload
branch
3 times, most recently
from
841e150
to
2d9f9c9
Compare
|
So uhhh... how's it going @joebonrichie |
Resolves BuddiesOfBudgie#281. Initially support imgur, imagebin and 0x0. Based on cybre's screen shotshot applet but ported to libsoup3.
Previously we were using the cloud upload svg from breeze.
Service has been down for several weeks, unreliable
meson: Lower libsoup3 requirement from 3.2.0 -> 3.0.7 for CI
We're passing a filepath, not an uri
Switch from using `send_and_read` to `send_and_read_async` and stick it in a loop. This unblocks the UI whilst a screenshot is uploading.
- Make methods all non-static - Reuse provider strings more effectively - Prevent unneeded soup and json parser reinitialization
joebonrichie
force-pushed
the
screenshot-upload
branch
from
2d9f9c9
to
67de3a6
Compare
|
What do you want done with imgur support? Comment it out, nuke it or hook up the apikey stuff needed for it to meson options? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #281.
Description
Based on cybre's screenshot applet but ported to libsoup3.
Supported providers
W.I.P image: https://i.imgur.com/myFzsHw.png
TODO:
emblem-shared-symbolicinstead of relying on the icon-theme?FEEDBACK WANTED:
Submitter Checklist
git rebase -i(if needed)