Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing rules #138

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Missing rules #138

merged 3 commits into from
Mar 7, 2024

Conversation

ximenesuk
Copy link
Collaborator

@ximenesuk ximenesuk commented Mar 7, 2024

Changes in the upstream library mean that files that previously broke with a "File read error" now pass with errors in rules 3, 4 and 5 and an AGS exception is no longer thrown. This change addresses that upstream change.

  • Tests should pass
  • File "A487 Pont ar Dyfi Improvement.ags" should parse with Rules 3,4 and 5 errors. It should also report a Rule ? error and a BGS file read error is BGS validation is enabled.

@KoalaGeo KoalaGeo merged commit f2c4ef3 into main Mar 7, 2024
1 check passed
@KoalaGeo KoalaGeo deleted the missing-rules branch March 7, 2024 11:04
@KoalaGeo
Copy link
Collaborator

KoalaGeo commented Mar 7, 2024

Fixes #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants