Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MA-50]: MM-61659: Provide fieldsets for groups of form controls #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SaurabhSharma-884
Copy link

@SaurabhSharma-884 SaurabhSharma-884 commented Jan 3, 2025

Summary

There are visually grouped form controls that are not programmatically grouped. Examples include:
Mute or ignore, Mute channel,..etc. This PR groups these inputs.

Steps to reproduce

  • Locate the "Mute or ignore, Mute channel,..etc." form field grouping.
  • Inspect it with Chrome DevTools.
  • In the Accessibility tab, expand the Computed Properties section.
  • Review the value for "Role".

Ticket Link

Fixes: https://mattermost.atlassian.net/browse/MM-61659

Screenshots

Screenshot from 2025-01-03 16-13-07

Release Note


Copy link
Collaborator

@ayush-chauhan233 ayush-chauhan233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants