Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MA-45]: Updated the heading element tag #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MA-45]: Updated the heading element tag #47

wants to merge 1 commit into from

Conversation

ayush-chauhan233
Copy link
Collaborator

Summary

  • Updated the user settings and team settings modal title component HTML tag from h1 to h2.

Steps to reproduce

  • Locate the Settings text heading.
  • Inspect it with Chrome DevTools.
  • In the Accessibility tab, expand the Computed Properties section.
  • Review the value for "Level".

Expected behaviour

  • The heading does not match with the visual level on the page, Hence the modal heading should be h2.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-61684

Screenshots

Before After

Release Note

NONE

@ayush-chauhan233 ayush-chauhan233 self-assigned this Dec 31, 2024
SaurabhSharma-884
SaurabhSharma-884 approved these changes Jan 13, 2025
View reviewed changes
webapp/channels/src/sass/components/_settings-modal.scss

&__title {
color: var(--center-channel-color);
font-family: 'Metropolis', serif;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From where are we adding these styles?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took reference from notification header
Screenshot from 2025-01-13 16-49-15

@ayush-chauhan233 ayush-chauhan233 added On External Approved Dev approved, ready to be reviewed by MM team labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaurabhSharma-884 SaurabhSharma-884 SaurabhSharma-884 approved these changes

Assignees

@ayush-chauhan233 ayush-chauhan233

Labels
Approved Dev approved, ready to be reviewed by MM team Merged On External
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayush-chauhan233 @SaurabhSharma-884