Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MA-49]: Removed visibility from visually hidden elements #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SaurabhSharma-884
Copy link

@SaurabhSharma-884 SaurabhSharma-884 commented Dec 30, 2024

Summary

Added Visibility hidden on collapsed theme options.

Steps to Reproduce

  • Open the Settings menu.
  • Navigate to the Display tab.
  • Go to the Theme section.
  • Select Custom Theme.
  • Choose the Copy and Paste text area.
  • The screen reader will announce the values of the styles in the accordion(Sidebar styles, Center Channel styles, Link and Button styles) above, which are visually hidden.

Expected Behaviour

The screen reader should only announce the styles associated with the Copy and Paste text area, not the styles for the Sidebar styles, Center Channel styles, Link and Button styles

Ticket Link

https://mattermost.atlassian.net/browse/MM-61681

Screenshots

before after
manual-issue-id-E147-screenshot-0 1000046299

Release Note

NONE

@ayush-chauhan233 ayush-chauhan233 added the Approved Dev approved, ready to be reviewed by MM team label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Dev approved, ready to be reviewed by MM team On External
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants