Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MA-43]: Updated the input grouping in notification setting tab #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MA-43]: Updated the input grouping in notification setting tab #40

wants to merge 1 commit into from

Conversation

ayush-chauhan233
Copy link
Collaborator

@ayush-chauhan233 ayush-chauhan233 commented Dec 26, 2024 •
edited
Loading

Summary

  • Wrapped the checkbox input with the fieldset tag.
  • Added legend tag for assistive technology to announce the information for grouping.

Steps to reproduce

  • Navigate to the Keywords that trigger notifications edit button and select it.
  • Now navigate to the Your non case-sensitive username "admin" checkbox.
  • Notice that the components are not grouped together.

Expected Behavior

  • Related form control should be grouped together so that screen reader can announce it as a group.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-61656

Screenshots

Before After

Release Note

NONE

@ayush-chauhan233 ayush-chauhan233 self-assigned this Dec 26, 2024
@ayush-chauhan233 ayush-chauhan233 added On External Approved Dev approved, ready to be reviewed by MM team labels Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaurabhSharma-884 SaurabhSharma-884 SaurabhSharma-884 approved these changes

Assignees

@ayush-chauhan233 ayush-chauhan233

Labels
Approved Dev approved, ready to be reviewed by MM team On External
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayush-chauhan233 @SaurabhSharma-884