Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MA-32]: Added logic to correctly give accessible name to channel header button #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[MA-32]: Added logic to correctly give accessible name to channel header button #34

wants to merge 2 commits into from

Conversation

ayush-chauhan233
Copy link
Collaborator

@ayush-chauhan233 ayush-chauhan233 commented Dec 24, 2024 •
edited
Loading

Summary

  • Added aria-labelled by to system bot heading in the channel header
  • Updated the aria-label on the channel header button to announce the channel name correctly.
  • Removed aria-label from the disable calls button

Steps to reproduce

  • Locate the Town Square button control.
  • Inspect it with Chrome DevTools.
  • In the Accessibility tab, expand the Computed Properties section.
  • Review the value for "Name".
  • Notice that this value does not include the visible text of the control as a substring.
  • Review the value for "Description".

Expected Behavior

  • The screen reader must announce the accessible button name correctly.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-61646

Screenshots

Before After

Release Note

NONE

@ayush-chauhan233 ayush-chauhan233 self-assigned this Dec 24, 2024
SaurabhSharma-884
SaurabhSharma-884 approved these changes Jan 6, 2025
View reviewed changes
webapp/channels/src/components/channel_header/channel_header_title.tsx Outdated
>
<span>
<span
id='channelHeaderTitle.bot'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id='channelHeaderTitle.bot'
id='channelHeaderTitle_bot'

@ayush-chauhan233 ayush-chauhan233 added On External Approved Dev approved, ready to be reviewed by MM team labels Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaurabhSharma-884 SaurabhSharma-884 SaurabhSharma-884 approved these changes

Assignees

@ayush-chauhan233 ayush-chauhan233

Labels
Approved Dev approved, ready to be reviewed by MM team On External
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayush-chauhan233 @SaurabhSharma-884