Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MA-22]: Added aria-live property for message sent status #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[MA-22]: Added aria-live property for message sent status #27

wants to merge 2 commits into from

Conversation

ayush-chauhan233
Copy link
Collaborator

Summary

  • Added aria-live property to the message status element.
  • Programmatically triggering the Message Sent prompt.

Steps to reproduce

  • Navigate to the write to town square edit field and type 'tester'.
  • Now navigate to the Send a message button and select it.
  • Notice that after selecting the Send a message button, the screen reader not announcing any status message.

Expected Behavior

  • When the message is successfully sent a screen should announce the status of sent message.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-61619

Screenshots

Before After

Release Note

NONE

@ayush-chauhan233 ayush-chauhan233 self-assigned this Dec 19, 2024
SaurabhSharma-884
SaurabhSharma-884 requested changes Dec 19, 2024
View reviewed changes
webapp/channels/src/components/advanced_text_editor/advanced_text_editor.tsx Outdated
position: 'absolute',
top: '-1000px',
}}
>{ }</div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why empty ?

webapp/channels/src/components/advanced_text_editor/advanced_text_editor.tsx Outdated
aria-live='assertive'
style={{
position: 'absolute',
top: '-1000px',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use class instead

@ayush-chauhan233 ayush-chauhan233 added On External Approved Dev approved, ready to be reviewed by MM team labels Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaurabhSharma-884 SaurabhSharma-884 SaurabhSharma-884 approved these changes

Assignees

@ayush-chauhan233 ayush-chauhan233

Labels
Approved Dev approved, ready to be reviewed by MM team On External
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayush-chauhan233 @SaurabhSharma-884