fix optional types

[natew]

No description provided.

[0xcadams]

Hey @natew, could you give me more context here so we can make sure this is fixed? The reason these types are this way is because the optional field is typed as boolean here, as opposed to keeping the type of the input.

https://github.com/rocicorp/mono/blob/85e3f0ee820609b8f6945e55c043b9ed55a9908a/packages/zero-schema/src/column.ts#L1

e.g. something like:

export function string<T extends string = string, O extends boolean = false>(optional: O = false) {
  return {
    type: 'string',
    optional,
    customType: null as unknown as T,
  } as const;
}

[natew]

You want it to be inferred. That way it matches the notNull. I went further and had it be optional also if there’s a default value which is correct too, as it matches what your database expects. It works perfectly on my schema I can link it when I get home later.

[0xcadams]

Sounds great - related PR here and I will update tests here and merge - thanks!

rocicorp/mono#3474

[0xcadams]

Added some other changes I've been working on - thanks!