S5 support #259
Merged
S5 support #259
+675
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith ignore errors
kavitharaju
merged commit 79a705d
into
Bridgeconn:js-tree-sitter-usfm-parser
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\s5 marker is treated as a valid \s# marker in our grammar. But there are issues in its usage witout space and without \p following it. I such cases, ignore errors option may helpout. But it was buggy in the node and web modules. This PR just fixes the error handling issues.
Alpha.9 versions are published for the node and web npm packages.
More steps could be taken when taking up Auto Fix Errors #242