Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BI-2372 Create Deltabreed List Controller #434

Merged
merged 9 commits into from
Jan 10, 2025
Merged

BI-2372 Create Deltabreed List Controller #434

merged 9 commits into from
Jan 10, 2025

Conversation

dmeidlin
Copy link
Contributor

@dmeidlin dmeidlin commented Nov 18, 2024 •
edited
Loading

Description

Story: BI-2372

  • Removed GET /germplasm/lists/<listDbId/records and replaced with GET /germplasm?list=<listDbId> to follow the pattern expected for BrAPI lists in the future.
  • Created DELETE /lists/ with hardDelete query param for deleting a single list entity, and not deleting the list contents.

Dependencies

  • Brapi-java-test-server branch brapi-server-v2

Testing

Testing is satisfied by successful testing of BI-2373.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@dmeidlin dmeidlin mentioned this pull request Dec 10, 2024
Merged
6 tasks
@dmeidlin dmeidlin requested review from mlm483 and HMS17 December 10, 2024 19:40
mlm483
mlm483 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working.

Consider renaming the GermplasmQuery list field to listId for clarity.

@dmeidlin dmeidlin marked this pull request as ready for review January 10, 2025 20:27
@dmeidlin dmeidlin merged commit 7fabdbf into develop Jan 10, 2025
1 check passed
@dmeidlin dmeidlin deleted the feature/BI-2372 branch January 10, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HMS17 HMS17 HMS17 approved these changes

@mlm483 mlm483 mlm483 approved these changes

Assignees

@mlm483 mlm483

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmeidlin @HMS17 @mlm483