Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-1265-2] Overwrite entity dataset #327

Merged
merged 3 commits into from
Jan 24, 2024
Merged

[BI-1265-2] Overwrite entity dataset #327

merged 3 commits into from
Jan 24, 2024

Conversation

dmeidlin
Copy link
Contributor

@dmeidlin dmeidlin commented Jan 18, 2024

Description

Story: BI-1265

During exp import processing, study season is fetched and assigned to additional info. The season value was being passed in as the season dbid and failing lookup in the database. The correct season value is now used.
Also, changes were made to avoid NPEs during update of brapi variables.

Dependencies

bi-web release/0.9

Testing

same as BI-1830

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Jan 18, 2024
Copy link
Contributor

@davedrp davedrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed developer testing

@dmeidlin dmeidlin merged commit fbaef30 into release/0.9 Jan 24, 2024
2 checks passed
@dmeidlin dmeidlin deleted the bug/BI-1265 branch January 24, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants