Merge pull request #161 from BrandonPotter/fix/30secondinterval

Fixed problem with 30 second interval
BrandonPotter · May 30, 2023 · edf9968 · edf9968
2 parents 7187f1f + ebecd17
commit edf9968
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 3 deletions.
diff --git a/Google.Authenticator.Tests/ValidationTests.cs b/Google.Authenticator.Tests/ValidationTests.cs
@@ -33,6 +33,32 @@ public void ValidateWorksWithDifferentSecretTypes(string pin, int irrelevantNumb
             subject.ValidateTwoFactorPIN(secretAsBytes, pin, irrelevantNumberToAvoidDuplicatePinsBeingRemoved * 2);
         }
 
+        [Fact]
+        public void GetCurrentPinsHandles15SecondInterval()
+        {
+            // This is nonsensical, really, as anything less than 30 == 0 in practice.
+            var subject = new TwoFactorAuthenticator();
+
+            subject.GetCurrentPINs(secret, TimeSpan.FromSeconds(15)).Length.ShouldBe(1);
+        }
+
+
+        [Fact]
+        public void GetCurrentPinsHandles30SecondInterval()
+        {
+            var subject = new TwoFactorAuthenticator();
+
+            subject.GetCurrentPINs(secret, TimeSpan.FromSeconds(30)).Length.ShouldBe(3);
+        }
+
+        [Fact]
+        public void GetCurrentPinsHandles60SecondInterval()
+        {
+            var subject = new TwoFactorAuthenticator();
+
+            subject.GetCurrentPINs(secret, TimeSpan.FromSeconds(60)).Length.ShouldBe(5);
+        }
+
         public static IEnumerable<object[]> GetPins()
         {
             var subject = new TwoFactorAuthenticator();

diff --git a/Google.Authenticator/Google.Authenticator.csproj b/Google.Authenticator/Google.Authenticator.csproj
@@ -1,12 +1,12 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFrameworks>netstandard2.0;net462</TargetFrameworks>
     <Product>Google Authenticator Two-Factor</Product>
     <Title>Google Authenticator Two-Factor Authentication Library</Title>
     <Description>Google Authenticator Two-Factor Authentication Library (Not officially affiliated with Google.)</Description>
     <Authors>Brandon Potter</Authors>
     <Company>Brandon Potter</Company>
-    <Version>3.1.0</Version>
+    <Version>3.1.1-beta1</Version>
     <PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
     <PackageProjectUrl>https://github.com/BrandonPotter/GoogleAuthenticator</PackageProjectUrl>
     <PackageId>GoogleAuthenticator</PackageId>

diff --git a/Google.Authenticator/TwoFactorAuthenticator.cs b/Google.Authenticator/TwoFactorAuthenticator.cs
@@ -303,7 +303,7 @@ public string[] GetCurrentPINs(byte[] accountSecretKey, TimeSpan timeTolerance)
         {
             var iterationOffset = 0;
 
-            if (timeTolerance.TotalSeconds > 30)
+            if (timeTolerance.TotalSeconds >= 30)
                 iterationOffset = Convert.ToInt32(timeTolerance.TotalSeconds / 30.00);
 
             return GetCurrentPINs(accountSecretKey, iterationOffset);

diff --git a/README.md b/README.md
@@ -33,6 +33,11 @@ bool result = tfa.ValidateTwoFactorPIN(key, txtCode.Text)
 
 ## Update history
 
+### 3.1.1-beta1
+Fixed an edge case where specifying an interval of 30 seconds to the Validate function would be treated as if you had passed in 0.
+
+### 3.1.0
+
 ### 3.0.0
 
 - Removed support for legacy .Net Framework. Lowest supported versions are now netstandard2.0 and .Net 4.6.2.