Skip to content

First commit for tsd metrics client for node.js #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cybermaak
Copy link
Collaborator

Remaining items:

  • Creating pacakge.json
  • Creating formal unit tests

Remaining items:
- Creating pacakge.json
- Creating formal unit tests
- Re-organize tests
- Create pacakge.json (already published to npm)
@cybermaak
Copy link
Collaborator Author

Update PR with the following:
Functional Changes:

  • Made the TsdMetrics class extend EvenEmitter and use that to surface errors
  • Modified the CounterSamples class to serialize the samples in the order they were create, rather than their reverse order

Non-functional changes:

  • Created package.jason for npm deployment and restructured the directories based on common practices
  • Rewrote tests in more structured ways (they are still semi-automated)
  • Managed the logger's singleton using new class Lazy. (sigh such simple things that comes out of the box in C#)
  • Added a bash script to compile the TS source into JS
  • Added more comments

@BrandonArp BrandonArp force-pushed the master branch 2 times, most recently from 2d90214 to b03bb7a Compare September 21, 2015 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant