Mlc #247
Draft
Mlc #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implemention is ostensibly complete, with the exception of missing OCaml-specific functionality in `Hmc.Scan`.
added 8 commits
September 16, 2024 20:19
This is OCaml-specific syntax.
The Hemlock scanner now directly supports long integer syntax, which made this code dead.
This is OCaml-specific syntax.
Fix raw string tag scanning to retry rather than advancing, so that replacement codepoints are checked for validity. Add tests for valid replacement codepoints. Invalid replacement codepoints are troublesome to embed in tests, and remain untested.
This is OCaml-specific syntax. Omit support for tags, e.g. `{tag|...|tag}`,
since doing so would substantially complicate scanning, and no extant code uses
tags.
Replace the `Binding` nonterm with `Uident` and use it in place of `UIDENT` everywhere possible.
Aliases are commonly punctuation, e.g. ";", which can make diagnostic output confusing if the quotes are omitted.
added 8 commits
October 6, 2024 23:44
This case can arise for ambiguous grammars which inherently contain reduce-reduce conflicts.
added 7 commits
October 7, 2024 13:54
This removes the weirdness around needing spaces to avoid comment syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.