Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK-1711 fix crash on iOS 12 when using the pre-built xcframework #1325

Merged
merged 1 commit into from
Dec 2, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions BranchSDK.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
@@ -1954,6 +1954,10 @@
"@loader_path/Frameworks",
);
MARKETING_VERSION = 3.0.1;
OTHER_LDFLAGS = (
"-weak_framework",
LinkPresentation,
);
PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK;
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
PROVISIONING_PROFILE_SPECIFIER = "";
@@ -1985,6 +1989,10 @@
"@loader_path/Frameworks",
);
MARKETING_VERSION = 3.0.1;
OTHER_LDFLAGS = (
"-weak_framework",
LinkPresentation,
);
PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK;
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
PROVISIONING_PROFILE_SPECIFIER = "";
@@ -2187,6 +2195,10 @@
);
MACH_O_TYPE = staticlib;
MARKETING_VERSION = 3.0.1;
OTHER_LDFLAGS = (
"-weak_framework",
LinkPresentation,
);
PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK;
PRODUCT_MODULE_NAME = BranchSDK;
PRODUCT_NAME = BranchSDK;
@@ -2222,6 +2234,10 @@
);
MACH_O_TYPE = staticlib;
MARKETING_VERSION = 3.0.1;
OTHER_LDFLAGS = (
"-weak_framework",
LinkPresentation,
);
PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK;
PRODUCT_MODULE_NAME = BranchSDK;
PRODUCT_NAME = BranchSDK;
@@ -2255,6 +2271,10 @@
"@loader_path/Frameworks",
);
MARKETING_VERSION = 3.0.1;
OTHER_LDFLAGS = (
"-weak_framework",
LinkPresentation,
);
PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK;
PRODUCT_NAME = BranchSDK;
PROVISIONING_PROFILE_SPECIFIER = "";
@@ -2286,6 +2306,10 @@
"@loader_path/Frameworks",
);
MARKETING_VERSION = 3.0.1;
OTHER_LDFLAGS = (
"-weak_framework",
LinkPresentation,
);
PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK;
PRODUCT_NAME = BranchSDK;
PROVISIONING_PROFILE_SPECIFIER = "";
5 changes: 5 additions & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
@@ -24,6 +24,11 @@ v.3.0.0
- pre-iOS 10 locale support
- Device carrier. This was used for fraud analysis, but is no longer available on new iOS versions.

v.2.3.1
This version is for a hotfix on Xamarin, it will not ship as a general iOS release.

- SDK-2179 Fix LinkPresentation linker issue causing crash on Xamarin when run on iOS 12 or iOS 13. Thanks @LeadAssimilator.

v.2.2.1

Branch iOS SDK 2.2.1 adds parameter for current SKAN 4.0 Window in /v1/open and /v2/event requests.
2 changes: 1 addition & 1 deletion scripts/version.sh
Original file line number Diff line number Diff line change
@@ -107,7 +107,7 @@ if [[ $update ]]; then
sed -i '' -e "/^[[:space:]]*s\.version/ {s/\".*\"/\"$version\"/; }" ../BranchSDK.podspec

# Update framework version
sed -ie 's/MARKETING_VERSION = '"$prev_version"'/MARKETING_VERSION = '"$version"'/g' ../BranchSDK.xcodeproj/project.pbxproj
sed -i '' -e 's/MARKETING_VERSION = '"$prev_version"'/MARKETING_VERSION = '"$version"'/g' ../BranchSDK.xcodeproj/project.pbxproj
fi