Prevent file descriptor leak and modernize BufferedWriter creation

[pixeeai]

This change prevents a file descriptor leak and modernizes the file writing API pattern.

The way the code is written now, the FileWriter never gets closed. Thus, it is up to the garbage collector's objection finalization process to close them at some point. This is not a good practice, and it can lead to a file descriptor leak. In hot code paths, it could cause exhaustion of all the available file descriptors for the system and lead to denial-of-service conditions.

Our changes look something like this:

-  BufferedWriter writer = new BufferedWriter(new FileWriter(f));
+  BufferedWriter writer = Files.newBufferedWriter(f.toPath());

More reading

• https://cwe.mitre.org/data/definitions/775.html

🧚🤖 Powered by Pixeebot

💬Feedback | 👥Community | 📚Docs | Codemod ID: pixee:java/prevent-filewriter-leak-with-nio

[pixeeai]

This change was autogenerated from a GitHub app - called Pixeebot. A code-quality GitHub App for source code.

Free installation for Open Source projects: 👇
https://github.com/marketplace/pixeebot-automated-code-fixes

[pixeeai]

Any chance you've had the time to review these changes?

If you're not interested implementing them at this time, no worries. I can close the PR and follow up with additional changes in the future. Also, this plugin is free for non-commercial open sourced projects, so feel free to give it an install if you want to see the other recommended PRs.

Thanks,
Zach