Skip to content

Commit

Permalink
GH Actions: PHP 8.4 has been released
Browse files Browse the repository at this point in the history
* Builds against PHP 8.4 are no longer allowed to fail.
* Add _allowed to fail_ build against PHP 8.5.

Note: running PHP 8.4 with `dependencies: lowest` will not work due to issues in Patchwork and Mockery, but raising the minimum versions of those dependencies would require dropping support for PHP < 7.1 (and maybe more).

Ref: https://www.php.net/releases/8.4/en.php
  • Loading branch information
jrfnl committed Nov 22, 2024
1 parent d95a9d8 commit 11f5cd8
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/php-qa.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ jobs:
include:
- php-versions: '8.4'
dependency-versions: 'highest'
- php-versions: '8.5'
dependency-versions: 'highest'

continue-on-error: ${{ matrix.php-versions == '8.4' }}
continue-on-error: ${{ matrix.php-versions == '8.5' }}

steps:
- uses: actions/checkout@v4
Expand All @@ -44,15 +46,15 @@ jobs:
run: parallel-lint ./src/ ./tests/

- name: Install dependencies - normal
if: ${{ matrix.php-versions != '8.4' }}
if: ${{ matrix.php-versions != '8.5' }}
uses: "ramsey/composer-install@v3"
with:
dependency-versions: ${{ matrix.dependency-versions }}
# Bust the cache at least once a month - output format: YYYY-MM.
custom-cache-suffix: $(date -u "+%Y-%m")

- name: Install dependencies - ignore-platform-reqs
if: ${{ matrix.php-versions == '8.4' }}
if: ${{ matrix.php-versions == '8.5' }}
uses: "ramsey/composer-install@v3"
with:
dependency-versions: ${{ matrix.dependency-versions }}
Expand Down

0 comments on commit 11f5cd8

Please sign in to comment.