Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger support #116

Merged
merged 18 commits into from
Jun 17, 2019
Merged

Add logger support #116

merged 18 commits into from
Jun 17, 2019

Conversation

ajtritt
Copy link
Collaborator

@ajtritt ajtritt commented Jun 15, 2019

Add logger to linear model classes

@codecov-io
Copy link

codecov-io commented Jun 17, 2019

Codecov Report

Merging #116 into master will decrease coverage by 1.65%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   93.04%   91.38%   -1.66%     
==========================================
  Files          16       16              
  Lines        1322     1370      +48     
==========================================
+ Hits         1230     1252      +22     
- Misses         92      118      +26
Impacted Files Coverage Δ
pyuoi/linear_model/lasso.py 100% <ø> (ø) ⬆️
pyuoi/linear_model/poisson.py 96.24% <ø> (ø) ⬆️
pyuoi/linear_model/logistic.py 95.11% <ø> (ø) ⬆️
pyuoi/linear_model/elasticnet.py 100% <ø> (ø) ⬆️
pyuoi/linear_model/base.py 80.13% <79.16%> (-12.21%) ⬇️
pyuoi/utils.py 96.49% <85.71%> (-1.51%) ⬇️
pyuoi/decomposition/NMF.py 88.09% <94.44%> (+14.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaf35ff...ca9039a. Read the comment docs.

Copy link
Member

@JesseLivezey JesseLivezey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than those 2 docstrings, LGTM. The failing logistic test is something I'm going to fix. It's slightly too strict and not related to your changes.

tests/test_nmf.py Show resolved Hide resolved
tests/test_nmf.py Show resolved Hide resolved
@JesseLivezey
Copy link
Member

For the fast/slow marks, do we need to make it so that the ones marked slow don't run on CI?

https://docs.pytest.org/en/latest/example/simple.html#control-skipping-of-tests-according-to-command-line-option

That could happen after this PR.

@ajtritt
Copy link
Collaborator Author

ajtritt commented Jun 17, 2019

@JesseLivezey

For the fast/slow marks, do we need to make it so that the ones marked slow don't run on CI?

I just created #117 for this.

@JesseLivezey
Copy link
Member

@ajtritt ready to merge?

@JesseLivezey JesseLivezey merged commit dbfb4d9 into master Jun 17, 2019
@ajtritt ajtritt deleted the enh/logger branch June 25, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants