-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logger support #116
Add logger support #116
Conversation
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
- Coverage 93.04% 91.38% -1.66%
==========================================
Files 16 16
Lines 1322 1370 +48
==========================================
+ Hits 1230 1252 +22
- Misses 92 118 +26
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than those 2 docstrings, LGTM. The failing logistic test is something I'm going to fix. It's slightly too strict and not related to your changes.
For the fast/slow marks, do we need to make it so that the ones marked slow don't run on CI? That could happen after this PR. |
I just created #117 for this. |
@ajtritt ready to merge? |
Add logger to linear model classes